Convert TestAbortBind to an acceptance test #3111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen run without an --auto-approve flag
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
pietern
reviewed
Jun 24, 2025
| grep "^Error:" out.bind-result.txt | ||
| rm out.bind-result.txt | ||
|
|
||
| title "Check that job is not bound and not updated with config from bundle:" |
There was a problem hiding this comment.
There is a missing deploy in between the failed bind and the job get.
There was a problem hiding this comment.
Good catch! I realized that this needs to be a separate test, created it here: #3116
There was a problem hiding this comment.
Pull Request Overview
This PR converts the original TestAbortBind integration test into an acceptance test to improve testing flexibility for different bundle deployment backing solutions.
- Removed the TestAbortBind integration test from the integration tests.
- Added new acceptance test steps in the job-spark-python-task acceptance test script and updated the expected output accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration/bundle/bind_resource_test.go | Removed the original TestAbortBind integration test. |
| acceptance/bundle/deployment/bind/job/job-spark-python-task/script | Added steps to simulate and verify binding failure without auto-approve and successful binding with auto-approve. |
| acceptance/bundle/deployment/bind/job/job-spark-python-task/output.txt | Updated expected output to match the new acceptance test steps. |
Comments suppressed due to low confidence (2)
acceptance/bundle/deployment/bind/job/job-spark-python-task/script:36
- [nitpick] Consider using a more specific pattern or dedicated assertion method to validate the full error message, which could help ensure that the test detects any unintended changes in the error output.
grep "^Error:" out.bind-result.txt
acceptance/bundle/deployment/bind/job/job-spark-python-task/script:35
- Consider verifying that the '&>' redirection syntax is supported in all target environments; if compatibility is a concern, replacing it with a POSIX-compliant redirection method may improve portability.
trace errcode $CLI bundle deployment bind foo $JOB_ID &> out.bind-result.txt
anton-107
added a commit
that referenced
this pull request
Jun 25, 2025
## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> One change in the series of changes for converting integration tests into acceptance tests. This will allow for easier testing of various backing solutions for bundle deployment This is a follow-up of the closed not-merged PR #3111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
One change in the series of changes for converting integration tests into acceptance tests.
This will allow for easier testing of various backing solutions for bundle deployment
Tests
Ran cloud and local versions of
bundle/deployment/bind/job/job-spark-python-taskClosed this PR, in favor of #3116