-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove imp dependency and test on python 3.12 #673
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
@@ -62,6 +62,7 @@ jobs: | |||
matrix: | |||
python-version: | |||
- '3.7' | |||
- '3.12' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also run this on all versions we support to be sure.
@mgyucht We might need to update the runner image to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there are only wheels for python 2 on pypi.
https://pypi.org/project/databricks-cli/#files
Can the universal option be added to the setup.py
? This will produce a python 2 and 3 compatible wheel.
setup(
...,
options={'bdist_wheel': {'universal': True}},
)
Current -- users get the sdist, which causes setup.py invocation, leading to this issue.
databricks_cli-0.17.8-py2-none-any.whl
databricks-cli-0.17.9.dev0.tar.gz
With universal - python 2 and 3 users get a wheel which is faster to install and doesn't invoke the setup.py.
databricks_cli-0.17.9.dev0-py2.py3-none-any.whl
databricks-cli-0.17.9.dev0.tar.gz
Also related to #631.
@jmahlik Yes, we've discussed and will do that in a follow-up PR. |
To enable users to use the databricks-cli library with Python 3.12, we must remove our use of the
imp
library. This is done in this PR as well as adding 3.12 to unit test coverage to ensure the package can be installed & used with Python 3.12.