Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Scope the traversing directory in the Recursive list workspace test #1120

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Jan 13, 2025

What changes are proposed in this pull request?

What - The PR modifies the scope of directory traversal in the recursive list test. It limits the search to the ".sdk" directory, where the relevant notebook is created.

Why - The test was previously hitting API rate limits because it was scanning too many elements in the current traversing directory. By narrowing the scope to the ".sdk" directory, the test can now run more efficiently without encountering these limits.

How is this tested?

This is itself an integration test.

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1120
  • Commit SHA: 9b3410f22e49329c5596cae74fac16cf383ec762

Checks will be approved automatically on success.

Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@parthban-db parthban-db added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 914ab6b Jan 13, 2025
16 checks passed
@parthban-db parthban-db deleted the parthban-db/scope-the-directory branch January 13, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants