Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Add test instructions for external contributors #804

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

hectorcast-db
Copy link
Contributor

Changes

Add test instructions for external contributors

Tests

See Go Changes
databricks/databricks-sdk-go#1073

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11573296249

@hectorcast-db hectorcast-db added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 52a2955 Oct 30, 2024
18 checks passed
@hectorcast-db hectorcast-db deleted the hectorcast-db/message-trigger branch October 30, 2024 09:23
renaudhartert-db added a commit that referenced this pull request Nov 4, 2024
### Bug Fixes

 * Correctly generate classes with nested body fields ([#808](#808)).

### Internal Changes

 * Add `cleanrooms` package ([#806](#806)).
 * Add test instructions for external contributors ([#804](#804)).
 * Always write message for manual test execution ([#811](#811)).
 * Automatically trigger integration tests on PR ([#800](#800)).
 * Better isolate ML serving auth unit tests ([#803](#803)).
 * Move templates in the code generator ([#809](#809)).

### API Changes:

 * Added [w.aibi_dashboard_embedding_access_policy](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_access_policy.html) workspace-level service and [w.aibi_dashboard_embedding_approved_domains](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_approved_domains.html) workspace-level service.
 * Added [w.credentials](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/credentials.html) workspace-level service.
 * Added `app_deployment` field for `databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `databricks.sdk.service.apps.UpdateAppRequest`.
 * Added `table` field for `databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Added `azure_aad` field for `databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
 * Added `full_name` field for `databricks.sdk.service.catalog.StorageCredentialInfo`.
 * Added `dashboard` field for `databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Added `schedule` field for `databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Added `subscription` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Added `warehouse_id` field for `databricks.sdk.service.dashboards.Schedule`.
 * Added `dashboard` field for `databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Added `schedule` field for `databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Added `page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
 * Added `next_page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
 * Added `connection_name` field for `databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
 * Added `is_no_public_ip_enabled` field for `databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
 * Added `external_customer_info` and `is_no_public_ip_enabled` fields for `databricks.sdk.service.provisioning.Workspace`.
 * Added `last_used_day` field for `databricks.sdk.service.settings.TokenInfo`.
 * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service with new required argument order.
 * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service . New request type is `databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` dataclass.
 * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service to type `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service.
 * Changed `create()`, `create_schedule()`, `create_subscription()` and `update_schedule()` methods for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service with new required argument order.
 * Removed [w.clean_rooms](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/clean_rooms.html) workspace-level service.
 * Removed `deployment_id`, `mode` and `source_code_path` fields for `databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Removed `description`, `name` and `resources` fields for `databricks.sdk.service.apps.CreateAppRequest`.
 * Removed `description` and `resources` fields for `databricks.sdk.service.apps.UpdateAppRequest`.
 * Removed `name` and `spec` fields for `databricks.sdk.service.catalog.CreateOnlineTableRequest`.
 * Removed `display_name`, `parent_path`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.CreateDashboardRequest`.
 * Removed `cron_schedule`, `display_name` and `pause_status` fields for `databricks.sdk.service.dashboards.CreateScheduleRequest`.
 * Removed `subscriber` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
 * Removed `display_name`, `etag`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.UpdateDashboardRequest`.
 * Removed `cron_schedule`, `display_name`, `etag` and `pause_status` fields for `databricks.sdk.service.dashboards.UpdateScheduleRequest`.
 * Removed `prev_page_token` field for `databricks.sdk.service.jobs.Run`.

OpenAPI SHA: 5285ce76f81314f342c1702d5c2ad4ef42488781, Date: 2024-11-04
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
### Bug Fixes

* Correctly generate classes with nested body fields
([#808](#808)).


### Internal Changes

* Add `cleanrooms` package
([#806](#806)).
* Add test instructions for external contributors
([#804](#804)).
* Always write message for manual test execution
([#811](#811)).
* Automatically trigger integration tests on PR
([#800](#800)).
* Better isolate ML serving auth unit tests
([#803](#803)).
* Move templates in the code generator
([#809](#809)).


### API Changes:

* Added
[w.aibi_dashboard_embedding_access_policy](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_access_policy.html)
workspace-level service and
[w.aibi_dashboard_embedding_approved_domains](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_approved_domains.html)
workspace-level service.
* Added
[w.credentials](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/credentials.html)
workspace-level service.
* Added `app_deployment` field for
`databricks.sdk.service.apps.CreateAppDeploymentRequest`.
 * Added `app` field for `databricks.sdk.service.apps.CreateAppRequest`.
 * Added `app` field for `databricks.sdk.service.apps.UpdateAppRequest`.
* Added `table` field for
`databricks.sdk.service.catalog.CreateOnlineTableRequest`.
* Added `azure_aad` field for
`databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`.
* Added `full_name` field for
`databricks.sdk.service.catalog.StorageCredentialInfo`.
* Added `dashboard` field for
`databricks.sdk.service.dashboards.CreateDashboardRequest`.
* Added `schedule` field for
`databricks.sdk.service.dashboards.CreateScheduleRequest`.
* Added `subscription` field for
`databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
* Added `warehouse_id` field for
`databricks.sdk.service.dashboards.Schedule`.
* Added `dashboard` field for
`databricks.sdk.service.dashboards.UpdateDashboardRequest`.
* Added `schedule` field for
`databricks.sdk.service.dashboards.UpdateScheduleRequest`.
* Added `page_token` field for
`databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`.
* Added `next_page_token` field for
`databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`.
* Added `connection_name` field for
`databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`.
* Added `is_no_public_ip_enabled` field for
`databricks.sdk.service.provisioning.CreateWorkspaceRequest`.
* Added `external_customer_info` and `is_no_public_ip_enabled` fields
for `databricks.sdk.service.provisioning.Workspace`.
* Added `last_used_day` field for
`databricks.sdk.service.settings.TokenInfo`.
* Changed `create()` method for
[w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html)
workspace-level service with new required argument order.
* Changed `execute_message_query()` method for
[w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html)
workspace-level service . New request type is
`databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest`
dataclass.
* Changed `execute_message_query()` method for
[w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html)
workspace-level service to type `execute_message_query()` method for
[w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html)
workspace-level service.
* Changed `create()`, `create_schedule()`, `create_subscription()` and
`update_schedule()` methods for
[w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html)
workspace-level service with new required argument order.
* Removed
[w.clean_rooms](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/clean_rooms.html)
workspace-level service.
* Removed `prev_page_token` field for `databricks.sdk.service.jobs.Run`.
* Removed `deployment_id`, `mode` and `source_code_path` fields for
`databricks.sdk.service.apps.CreateAppDeploymentRequest`.
* Removed `description`, `name` and `resources` fields for
`databricks.sdk.service.apps.CreateAppRequest`.
* Removed `description` and `resources` fields for
`databricks.sdk.service.apps.UpdateAppRequest`.
* Removed `name` and `spec` fields for
`databricks.sdk.service.catalog.CreateOnlineTableRequest`.
* Removed `display_name`, `parent_path`, `serialized_dashboard` and
`warehouse_id` fields for
`databricks.sdk.service.dashboards.CreateDashboardRequest`.
* Removed `cron_schedule`, `display_name` and `pause_status` fields for
`databricks.sdk.service.dashboards.CreateScheduleRequest`.
* Removed `subscriber` field for
`databricks.sdk.service.dashboards.CreateSubscriptionRequest`.
* Removed `display_name`, `etag`, `serialized_dashboard` and
`warehouse_id` fields for
`databricks.sdk.service.dashboards.UpdateDashboardRequest`.
* Removed `cron_schedule`, `display_name`, `etag` and `pause_status`
fields for `databricks.sdk.service.dashboards.UpdateScheduleRequest`.

OpenAPI SHA: 5285ce76f81314f342c1702d5c2ad4ef42488781, Date: 2024-11-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants