Convert Dashboard objects to dict in LakeviewAPI create and update methods
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
github-merge-queue bot
pushed a commit
to databrickslabs/ucx
that referenced
this pull request
Nov 18, 2024
Pin Databricks SDK to minor version to circumvent the problems with the [0.37.0 release](https://github.com/databricks/databricks-sdk-py/releases/tag/v0.37.0). Will unpin later when we resolved that issues. Waiting on solution in: - [ ] [lsql](databrickslabs/lsql#320) - [ ] [Databricks python sdk](databricks/databricks-sdk-py#824)
github-merge-queue bot
pushed a commit
to databrickslabs/ucx
that referenced
this pull request
Nov 18, 2024
Pin Databricks SDK to minor version to circumvent the problems with the [0.37.0 release](https://github.com/databricks/databricks-sdk-py/releases/tag/v0.37.0). Will unpin later when we resolved that issues. Waiting on solution in: - [ ] [lsql](databrickslabs/lsql#320) - [ ] [Databricks python sdk](databricks/databricks-sdk-py#824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Convert
Dashboardobjects to dict inLakeviewAPIcreateandupdatemethods. The API expects a JSON serializable object where the Python dataclasses are not. By converting these dataclass instances to dicts the objects become JSON serializable.This issue
_apiattribute misses type hintingLakeviewAPImethodsHow is this tested?
Did not look into testing this.