Skip to content

Commit

Permalink
Skip BizarroCharacterFKResolutionTest and DifficultParametersTest with
Browse files Browse the repository at this point in the history
reasoning.

This leaves just a few more suites to review.

Signed-off-by: Jesse Whitehouse <[email protected]>
  • Loading branch information
Jesse Whitehouse committed Oct 18, 2023
1 parent 448334f commit e102f87
Showing 1 changed file with 26 additions and 6 deletions.
32 changes: 26 additions & 6 deletions src/databricks/sqlalchemy/test/test_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -344,16 +344,18 @@ def test_reflect_covering_index(self):
def test_reflect_expression_based_indexes(self):
pass

@pytest.mark.skip(reason="Databricks doesn't enforce String or VARCHAR length limitations.")
@pytest.mark.skip(
reason="Databricks doesn't enforce String or VARCHAR length limitations."
)
def test_varchar_reflection(self):
"""Even if a user specifies String(52), Databricks won't enforce that limit.
"""
"""Even if a user specifies String(52), Databricks won't enforce that limit."""
pass

@pytest.mark.skip(reason="This dialect doesn't implement foreign key options checks.")
@pytest.mark.skip(
reason="This dialect doesn't implement foreign key options checks."
)
def test_get_foreign_key_options(self):
"""It's not clear from the test code what the expected output is here. Further research required.
"""
"""It's not clear from the test code what the expected output is here. Further research required."""
pass


Expand Down Expand Up @@ -528,3 +530,21 @@ class QuotedNameArgumentTest(QuotedNameArgumentTest):
also checks the behaviour of DDL identifier preparation process. We need to override some of IdentifierPreparer
methods because these are the ultimate control for whether or not CHECK and UNIQUE constraints are emitted.
"""


@pytest.mark.reviewed
@pytest.mark.skip(reason="Implementation deferred. See test_suite.py")
class BizarroCharacterFKResolutionTest:
"""Some of the combinations in this test pass. Others fail. Given the esoteric nature of these failures,
we have opted to defer implementing fixes to a later time, guided by customer feedback. Passage of
these tests is not an acceptance criteria for our dialect.
"""


@pytest.mark.reviewed
@pytest.mark.skip(reason="Implementation deferred. See test_suite.py")
class DifficultParametersTest:
"""Some of the combinations in this test pass. Others fail. Given the esoteric nature of these failures,
we have opted to defer implementing fixes to a later time, guided by customer feedback. Passage of
these tests is not an acceptance criteria for our dialect.
"""

0 comments on commit e102f87

Please sign in to comment.