[PECO-1109] Parameterized Query: add suport for inferring decimal types #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
susodapop
changed the title
added 3 commits
September 25, 2023 14:00
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
force-pushed
the
peco-1109
branch
from
3a84db3 to
99f1364
Compare
susodapop
commented
Sep 25, 2023
src/databricks/sql/utils.py
Outdated
| STRING = "STRING" | ||
| DATE = "DATE" | ||
| TIMESTAMP = "TIMESTAMP" | ||
| FLOAT = "FLOAT" | ||
| DECIMAL = "DECIMAL" | ||
| DECIMAL = "DECIMAL(6,2)" |
There was a problem hiding this comment.
If we keep this as just DECIMAL then DBR will create a decimal with zero precision after the decimal point because in Databricks SQL
SELECT CAST("1234.56" as DECIMAL)returns 1235
Whereas
SELECT CAST("1234.56" as DECIMAL(6,2))returns 1234.56
There was a problem hiding this comment.
As of 1565700 I've implemented dynamic casting and removed the DECIMAL(6,2) default
added 2 commits
September 25, 2023 15:58
Signed-off-by: Jesse Whitehouse <[email protected]>
…provided Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
This lets us make an easier to understand series of assertions about Decimal inference Note that `test_infer_types_decimal` tests a slightly different thing than its predecessor: the predecessor would pass a Python float into the inference but force its DbsqlParameter type to DECIMAL This causes the float value to be coerced. But this is an antipattern in Python. If the user explicitly sets a DbsqlParameter object to type DECIMAL then the user should also pass it a Python Decimal() object as its value, not a float Signed-off-by: Jesse Whitehouse <[email protected]>
added 2 commits
September 25, 2023 17:22
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
|
The python 3.8 lint check is hanging. Merging without this check passing as it passes for numerous other versions and appears to just be flaky. |
|
Also, we need to update the changelog to discuss the new parameterisation features. But we can punt this to a subsequent PR as there is more work to do before this releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This connector has strong support for Python Decimal types. But the parameterized query implementation merged last week is missing the ability to infer them. This pull request implements type inference for decimals with e2e tests for four different scenarios:
Decimal()object (type must be inferred)Decimal()parameter value is wrapped inDbsqlParameterwith thetypeset toNone(type must be inferred)Decimal()parameter value is wrapped inDbsqlParameterand the type is set toDbsqlType.DECIMAL(type is not inferred but cast expression must be calculated)Decimal()parameter value is wrapped inDbsqlParameterand the type is set to a custom implementation (type is not inferred and cast expression is accepted from the user as-is)In the first three scenarios, pysql will inspect the passed Decimal and provide the appropriate Databricks SQL cast expression to contain that decimal (such as
DECIMAL(18,2)orDECIMAL(38,5))I also split out the
infer_typestests so we can make special assertions about decimals and ranisortover a couple of files.I'll open a subsequent PR with a full example of how users can work with these APIs.