Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PECO-1083] Updated thrift files and added check for protocol version" #237

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

susodapop
Copy link
Contributor

Reverts #229 as it causes all of our e2e tests to fail on some versions of DBR.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Contributor

@nithinkdb nithinkdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susodapop susodapop merged commit 9afb215 into main Oct 2, 2023
14 of 15 checks passed
@susodapop susodapop deleted the revert-229-PECO-1083 branch October 2, 2023 16:43
@susodapop susodapop requested review from benc-db and nithinkdb October 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants