Fix syntax error in http handler #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
andreid-db
reviewed
Oct 19, 2023
| @@ -191,7 +189,7 @@ def flush(self): | |||
|
|
|||
| # Saves the cookie sent by the server response | |||
| if "Set-Cookie" in self.headers: | |||
| self.setCustomHeaders(dict("Cookie", self.headers["Set-Cookie"])) | |||
| self.setCustomHeaders({"Cookie", self.headers["Set-Cookie"]}) | |||
There was a problem hiding this comment.
I don't think setCustomHeaders is correct here, this will replace all existing headers . Shouldn't it be something like headers.update to append ?
|
Close in favor of newer PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code path never runs from DBR because we never send a
Set-Cookieheader. But some internal users during testing have found this codepath raises a syntax error.