Update Thrift package

[m1n0]

Resolves #394

[m1n0]

This is a very simple change, could we get workflow approval for tests to run please?

[susodapop]

This change LGTM.

[m1n0]

Thanks for the review and approval! All tests fail on an seemingly unrelated error though, any advice?

[susodapop]

@m1n0 interesting! I checked out your branch and tried the unit tests and everything passed. Looks like something changed on github that results in these failures.

[edit 12 Jun 2024 15:05:45] Here are the results from running the unit tests on Python 3.11

databricks-sql-connector-py3.12jessewhitehouse@whitehouse-mbp21 databricks-sql-python % poetry run python -m pytest tests/unit         
============================================================================================= test session starts =============================================================================================
platform darwin -- Python 3.11.7, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/jessewhitehouse/Developer/databricks-sql-python
configfile: pyproject.toml
plugins: dotenv-0.5.2
collected 312 items                                                                                                                                                                                           

tests/unit/test_arrow_queue.py ..                                                                                                                                                                       [  0%]
tests/unit/test_auth.py .........                                                                                                                                                                       [  3%]
tests/unit/test_client.py .........................................................................................s............s.......                                                                [ 38%]
tests/unit/test_cloud_fetch_queue.py ..............                                                                                                                                                     [ 43%]
tests/unit/test_download_manager.py ................                                                                                                                                                    [ 48%]
tests/unit/test_downloader.py ...........                                                                                                                                                               [ 51%]
tests/unit/test_endpoint.py ...                                                                                                                                                                         [ 52%]
tests/unit/test_fetches.py ........                                                                                                                                                                     [ 55%]
tests/unit/test_fetches_bench.py s                                                                                                                                                                      [ 55%]
tests/unit/test_init_file.py .                                                                                                                                                                          [ 56%]
tests/unit/test_issue_292.py .                                                                                                                                                                          [ 56%]
tests/unit/test_oauth_persistence.py ..                                                                                                                                                                 [ 57%]
tests/unit/test_param_escaper.py ............s.......                                                                                                                                                   [ 63%]
tests/unit/test_parameters.py ................................................                                                                                                                          [ 78%]
tests/unit/test_retry.py ....                                                                                                                                                                           [ 80%]
tests/unit/test_thrift_backend.py ..............................................................                                                                                                        [100%]

======================================================================================= 308 passed, 4 skipped in 14.43s =======================================================================================

[susodapop]

Looks like this is caused by a broader issue in virtualenv that is affecting many other developers: pypa/virtualenv#2735

The solution is to force github actions to rebuild its virtualenvs (rather than caching them). I'm not quite clear how to force that since I can't see the GH Actions panel for this repo anymore. But this should be enough information to fix things, @kravets-levko

[susodapop]

Yep, the tests are failing because actions/cache@v2 is pulling a cached version of the environment which was most recently rebuilt using a version of filelock that has since been yanked. Here are the instructions for blowing away this cache so that GH Actions can rebuild it. This will cause the tests to pass.

[edit 12 Jun 2024 15:10:44] It would be good to implement this pattern so that caches are rebuilt per-pull request. If this were in place today then a contributor could workaround the bug by closing and reopening their pull request with a new branch name. Which is...inelegant...but wouldn't block awaiting repository maintainer interaction.

[m1n0]

Thanks everyone!