Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI after the connector package split #464

Closed
wants to merge 4 commits into from
Closed

Fix CI after the connector package split #464

wants to merge 4 commits into from

Conversation

jackyhu-db
Copy link
Collaborator

No description provided.

@jackyhu-db jackyhu-db force-pushed the connector-split-ci-fix branch 4 times, most recently from 163a416 to d2390ba Compare November 1, 2024 03:23
@jackyhu-db jackyhu-db force-pushed the connector-split-ci-fix branch from d2390ba to 915e550 Compare November 1, 2024 03:33
yunbodeng-db
yunbodeng-db reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@yunbodeng-db yunbodeng-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a PR description?
I think you also refactor the organization a little bit. It's worth documenting.

@jackyhu-db
Copy link
Collaborator Author

Can you add a PR description? I think you also refactor the organization a little bit. It's worth documenting.

This is not the PR to main branch, it is the PR to the sqlalphmey package split branch created by @jprakash-db as I found he did not include the CI change so when he is going to merge split to main, all the CI will fail. I am creating this PR to test the github actions to make sure they still work after he merges the split branch to main.

benc-db
benc-db reviewed Nov 1, 2024
View reviewed changes
.github/workflows/build.yml
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ 3.8, 3.9, "3.10", "3.11" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should consider the change we made in dbt, as Python 3.8 is end of life, Python 3.12 has been out for a while, and python 3.13 was released last month.

@jackyhu-db jackyhu-db closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunbodeng-db yunbodeng-db yunbodeng-db left review comments

@benc-db benc-db benc-db approved these changes

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackyhu-db @benc-db @yunbodeng-db