Skip to content

Commit

Permalink
Fix build platform detection (#1174)
Browse files Browse the repository at this point in the history
Made a mistake when setting up build_platform env var - it worked on
macos, but linux machines produced platform ids incompatible with the
CLI releases
  • Loading branch information
ilia-db authored Apr 8, 2024
1 parent 5b4f896 commit 97c6d8b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/create-build-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
working-directory: packages/databricks-vscode
env:
GH_TOKEN: ${{ github.token }}
BUILD_PLATFORM_ARCH: linux_amd64

- uses: actions/upload-artifact@v3
with:
Expand Down
4 changes: 3 additions & 1 deletion packages/databricks-vscode/scripts/package-vsix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ esac
# This CLI is used to request metadata about CLIs terraform dependencies.
if [ ! -d ./.build ]; then
mkdir ./.build
BUILD_PLATFORM_ARCH="$(uname -s | awk '{print tolower($0)}')_$(uname -m)"
if [ -z "$BUILD_PLATFORM_ARCH" ]; then
BUILD_PLATFORM_ARCH="$(uname -s | awk '{print tolower($0)}')_$(uname -m)"
fi
./scripts/fetch-databricks-cli.sh $BUILD_PLATFORM_ARCH ./.build
fi

Expand Down

0 comments on commit 97c6d8b

Please sign in to comment.