Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always map java.sql.Types.BIGINT to LongType #311

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Always map java.sql.Types.BIGINT to LongType #311

wants to merge 4 commits into from
+15 −1

Commits on Dec 9, 2016

  1. Update RedshiftJDBCWrapper.scala 

    java.sql.Types.BIGINT => LongType in all cases for Redshift.
Redshift has no unsigned BigInt, and thus BigInt maps to Long without loss of resolution.
    @ngerstle
    ngerstle authored Dec 9, 2016
    Configuration menu
    Copy the full SHA
    d79ea87 View commit details
    Browse the repository at this point in the history

  2. Adding regression tests for LongType errors 

    Errors/unusually behavior is associated with BigInts.
Specifically, a count(column) query sometimes returns doubles rather than longs, as would be expected from the count function (which only provides signed BigInts).
    @ngerstle
    ngerstle authored Dec 9, 2016
    Configuration menu
    Copy the full SHA
    6a16c4b View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2017

  1. Remove excess whitespace from new test cases.

    @JoshRosen
    JoshRosen authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    3809fea View commit details
    Browse the repository at this point in the history

  2. More whitespace fixes.

    @JoshRosen
    JoshRosen authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    de15c0c View commit details
    Browse the repository at this point in the history