Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for TIMESTAMPTZ as a Timestamp field to support the Am… #367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jontradesy
Copy link

@jontradesy jontradesy commented Oct 11, 2017

Adding support for Amazon Redshift JDBC Driver 1.2.8.

Redshift JDBC drivers of version 1.2.8 and later now treat the TIMESTAMPTZ (timestamp with a timezone) data type as a TIMESTAMP instead of a VARCHAR (release notes here). The current timestamp parser cannot handle timestamps with timezone information (ex. 2017-09-22 14:03:11.503+03). This fix will parse timestamps with a timezone and normalize them to UTC time. For example the TIMESTAMPTZ value 2017-09-22 14:03:11.503+03 will be normalized to 2017-09-22 11:03:11.503 (note the 3 hour shift).

Test Updates

The tests now use the latest JDBC Redshift driver as defined by

"com.amazon.redshift" % "redshift-jdbc42" % "1.2.8.1005"

Test cases have been added for TIMESTAMPTZ fields

Versioning

The inherent backwards incompatibility of the Redshift JDBC Driver 1.2.8 suggests that this update should be a major release as defined by semantic versioning.

The Migration Guide in the README is updated to include the changes necessary to use the new version.

@ahharu
Copy link

ahharu commented May 10, 2018

please!!! this is breaking our AWS Glue code all of a sudden!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants