Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default branch from master to main #3174

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Change default branch from master to main #3174

merged 3 commits into from
Jan 29, 2024

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 29, 2024

Changes

To align with all other SDK/CLI repos, we align on naming the default branch main instead of master.

Once this is merged, I will rename the default branch name to main.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from a team as code owners January 29, 2024 15:10
@mgyucht mgyucht requested review from tanmay-db and removed request for a team January 29, 2024 15:10
@codecov-commenter
Copy link

Codecov Report

Attention: 546 lines in your changes are missing coverage. Please review.

Comparison is base (754aad4) 88.21% compared to head (943bd0c) 83.16%.
Report is 304 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
- Coverage   88.21%   83.16%   -5.06%     
==========================================
  Files         145      168      +23     
  Lines       11989    14811    +2822     
==========================================
+ Hits        10576    12317    +1741     
- Misses        930     1770     +840     
- Partials      483      724     +241     
Files Coverage Δ
access/resource_ip_access_list.go 80.95% <100.00%> (ø)
access/resource_permission_assignment.go 95.45% <100.00%> (+0.10%) ⬆️
aws/resource_service_principal_role.go 73.33% <100.00%> (ø)
catalog/data_current_metastore.go 100.00% <100.00%> (ø)
catalog/data_metastores.go 84.61% <100.00%> (ø)
catalog/resource_table.go 100.00% <100.00%> (ø)
catalog/resource_volume.go 87.87% <100.00%> (+3.87%) ⬆️
catalog/update.go 90.00% <100.00%> (-10.00%) ⬇️
catalog/utils.go 100.00% <100.00%> (ø)
clusters/data_spark_version.go 94.73% <100.00%> (+0.19%) ⬆️
... and 50 more

... and 37 files with indirect coverage changes

@mgyucht mgyucht added this pull request to the merge queue Jan 29, 2024
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have much more mentions of master:

  • in README.md: build]
  • in CONTRIBUTING.md
  • in docs - references to images

@mgyucht mgyucht removed this pull request from the merge queue due to a manual request Jan 29, 2024
@mgyucht
Copy link
Contributor Author

mgyucht commented Jan 29, 2024

Yes, but I think that when renaming the branch, those will continue to work: https://github.com/github/renaming

@mgyucht mgyucht added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 86d78e2 Jan 29, 2024
5 checks passed
@mgyucht mgyucht deleted the main branch January 29, 2024 15:20
tanmay-db added a commit that referenced this pull request Feb 5, 2024
### New Features and Improvements
* Exporter: timestamps are now added to log entries ([#3146](#3146)).
* Validate metastore id for databricks_grant and databricks_grants resources ([#3159](#3159)).
* Exporter: Skip emitting of clusters that come from more cluster sources ([#3161](#3161)).
* Fix typo in docs ([#3166](#3166)).
* Migrate cluster schema to use the go-sdk struct ([#3076](#3076)).
* Introduce Generic Settings Resource ([#2997](#2997)).
* Update actions/setup-go to v5 ([#3154](#3154)).
* Change default branch from `master` to `main` ([#3174](#3174)).
* Add .codegen.json configuration ([#3180](#3180)).
* Exporter: performance improvements for big workspaces ([#3167](#3167)).
* update ([#3192](#3192)).
* Exporter: fix generation of cluster policy resources ([#3185](#3185)).
* Fix unit test ([#3201](#3201)).
* Suppress diff should apply to new fields added in the same chained call to CustomizableSchema ([#3200](#3200)).
* Various documentation updates ([#3198](#3198)).
* Use common.Resource consistently throughout the provider ([#3193](#3193)).
* Extending customizable schema with `AtLeastOneOf`, `ExactlyOneOf`, `RequiredWith` ([#3182](#3182)).
* Fix `databricks_connection` regression when creating without owner ([#3186](#3186)).
* add test code for job task order ([#3183](#3183)).
* Allow using empty strings as job parameters ([#3158](#3158)).
* Fix notebook parameters in acceptance test ([#3205](#3205)).
* Exporter: Add retries for `Search`, `ReadContext` and `Import` operations when importing the resource ([#3202](#3202)).
* Fixed updating owners for UC resources ([#3189](#3189)).
* Adds `databricks_volumes` as data source  ([#3150](#3150)).

### Documentation Changes

### Exporter

### Internal Changes
@tanmay-db tanmay-db mentioned this pull request Feb 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2024
* Release v1.35.1

### New Features and Improvements
* Exporter: timestamps are now added to log entries ([#3146](#3146)).
* Validate metastore id for databricks_grant and databricks_grants resources ([#3159](#3159)).
* Exporter: Skip emitting of clusters that come from more cluster sources ([#3161](#3161)).
* Fix typo in docs ([#3166](#3166)).
* Migrate cluster schema to use the go-sdk struct ([#3076](#3076)).
* Introduce Generic Settings Resource ([#2997](#2997)).
* Update actions/setup-go to v5 ([#3154](#3154)).
* Change default branch from `master` to `main` ([#3174](#3174)).
* Add .codegen.json configuration ([#3180](#3180)).
* Exporter: performance improvements for big workspaces ([#3167](#3167)).
* update ([#3192](#3192)).
* Exporter: fix generation of cluster policy resources ([#3185](#3185)).
* Fix unit test ([#3201](#3201)).
* Suppress diff should apply to new fields added in the same chained call to CustomizableSchema ([#3200](#3200)).
* Various documentation updates ([#3198](#3198)).
* Use common.Resource consistently throughout the provider ([#3193](#3193)).
* Extending customizable schema with `AtLeastOneOf`, `ExactlyOneOf`, `RequiredWith` ([#3182](#3182)).
* Fix `databricks_connection` regression when creating without owner ([#3186](#3186)).
* add test code for job task order ([#3183](#3183)).
* Allow using empty strings as job parameters ([#3158](#3158)).
* Fix notebook parameters in acceptance test ([#3205](#3205)).
* Exporter: Add retries for `Search`, `ReadContext` and `Import` operations when importing the resource ([#3202](#3202)).
* Fixed updating owners for UC resources ([#3189](#3189)).
* Adds `databricks_volumes` as data source  ([#3150](#3150)).

### Documentation Changes

### Exporter

### Internal Changes

* upd

* readable

* upd

* upd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants