-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vector Search Endpoints #3191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple small nits.
How do we want to deal with the very long-running integration test?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3191 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 168 169 +1
Lines 15083 15132 +49
=======================================
+ Hits 12606 12647 +41
- Misses 1736 1740 +4
- Partials 741 745 +4
|
e221fe7
to
8370ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments.
Unit & integration tests needs to be added...
Co-authored-by: Miles Yucht <[email protected]>
Co-authored-by: Miles Yucht <[email protected]>
ca5bc0d
to
662e960
Compare
Changes
Added initial support for Databricks Vector Search endpoints that are the base for adding Vector Search Indexes.
It's not clear about adding an integration test - the provisioning of the endpoints is quite a long process (~25-30 minutes).
Tests
make test
run locallydocs/
folderinternal/acceptance