Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vector Search Endpoints #3191

Merged
merged 14 commits into from
Feb 15, 2024
Merged

Add support for Vector Search Endpoints #3191

merged 14 commits into from
Feb 15, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 31, 2024

Changes

Added initial support for Databricks Vector Search endpoints that are the base for adding Vector Search Indexes.

It's not clear about adding an integration test - the provisioning of the endpoints is quite a long process (~25-30 minutes).

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners January 31, 2024 16:47
@alexott alexott requested review from tanmay-db and removed request for a team January 31, 2024 16:47
@alexott alexott changed the title WIP: Add support for Vector Search Endpoints Add support for Vector Search Endpoints Jan 31, 2024
@alexott alexott mentioned this pull request Feb 1, 2024
1 task
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple small nits.

How do we want to deal with the very long-running integration test?

vectorsearch/resource_vector_search_endpoint.go Outdated Show resolved Hide resolved
vectorsearch/resource_vector_search_endpoint.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4213468) 83.57% compared to head (ca5bc0d) 83.57%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3191   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         168      169    +1     
  Lines       15083    15132   +49     
=======================================
+ Hits        12606    12647   +41     
- Misses       1736     1740    +4     
- Partials      741      745    +4     
Files Coverage Δ
provider/provider.go 94.47% <100.00%> (+0.03%) ⬆️
vectorsearch/resource_vector_search_endpoint.go 79.16% <79.16%> (ø)

... and 1 file with indirect coverage changes

@alexott alexott force-pushed the vector-search-support branch 4 times, most recently from e221fe7 to 8370ff1 Compare February 2, 2024 15:08
@alexott alexott requested a review from mgyucht February 5, 2024 09:38
Copy link
Contributor

@tanmay-db tanmay-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some comments.

docs/resources/vector_search_endpoint.md Outdated Show resolved Hide resolved
docs/resources/vector_search_endpoint.md Outdated Show resolved Hide resolved
docs/resources/vector_search_endpoint.md Outdated Show resolved Hide resolved
docs/resources/vector_search_endpoint.md Outdated Show resolved Hide resolved
@alexott alexott force-pushed the vector-search-support branch from ca5bc0d to 662e960 Compare February 14, 2024 14:43
@alexott alexott added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit bc5dcb5 Feb 15, 2024
5 checks passed
@alexott alexott deleted the vector-search-support branch February 15, 2024 12:20
@hectorcast-db hectorcast-db mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants