[Internal] Generate both SdkV2-compatible and Plugin Framework-compatible structures #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
approved these changes
Dec 19, 2024
rauchy
reviewed
Dec 19, 2024
| @@ -2289,7 +2289,7 @@ type ShareInfo struct { | |||
| // A list of shared data objects within the share. | |||
| Objects types.List `tfsdk:"object" tf:"optional"` | |||
| // Username of current owner of share. | |||
| Owner types.String `tfsdk:"owner" tf:"computed,optional"` | |||
| Owner types.String `tfsdk:"owner" tf:"computed"` | |||
There was a problem hiding this comment.
Suggested change
| Owner types.String `tfsdk:"owner" tf:"computed"` | |
| Owner types.String `tfsdk:"owner" tf:"computed,optional"` |
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Only diff is in that databricks_share_pluginframework's |
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Test Details: go/deco-tests/12416891035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To make it possible to implement new resources following the Plugin Framework's recommendation to use attributes while allowing resources to be migrated from SDKv2 to the Plugin Framework without breaking, we will create two copies of each code-generated structure in the Terraform provider. The structures with no suffix should be used for new resources. The structures with the
_SdkV2suffix should be used for resources in the plugin framework that are migrated from SDKv2.Tests
make testrun locallydocs/folderinternal/acceptance