cherry pick upstream fix to memorize tsdb client #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thanos-io#7941) * [Receive] fix race condition Signed-off-by: Yi Jin <[email protected]> * add a change log Signed-off-by: Yi Jin <[email protected]> * memorize tsdb local clients without race condition Signed-off-by: Yi Jin <[email protected]> * fix data race in testing with some concurrent safe helper functions Signed-off-by: Yi Jin <[email protected]> * address comments Signed-off-by: Yi Jin <[email protected]> --------- Signed-off-by: Yi Jin <[email protected]>
Signed-off-by: Yi Jin <[email protected]>
jnyi
commented
Dec 13, 2024
| tenants := make([]string, 0, len(t.tenants)) | ||
| for tname := range t.tenants { | ||
| tenants = append(tenants, tname) | ||
| } | ||
| defer t.mtx.RUnlock() |
There was a problem hiding this comment.
aha, found a potential bug cc @yuchen-db, you should defer Unlock right after, otherwise if there is a return statement in between, the lock won't be released ever.
jnyi
commented
Dec 13, 2024
| @@ -1215,74 +1215,3 @@ func TestReceiveCpnp(t *testing.T) { | |||
| }, v) | |||
|
|
|||
| } | |||
|
|
|||
| func TestNewTenant(t *testing.T) { | |||
There was a problem hiding this comment.
remove this test introduced in #100 which didn't capture the bug anyway
yuchen-db
approved these changes
Dec 13, 2024
| tenants := make([]string, 0, len(t.tenants)) | ||
| for tname := range t.tenants { | ||
| tenants = append(tenants, tname) | ||
| } | ||
| defer t.mtx.RUnlock() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTenantsChanges
Verification