Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Querier's error message #92

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

hczhu-db
Copy link
Collaborator

@hczhu-db hczhu-db commented Nov 1, 2024

Querier returns multiple errors when multiple Stores fail or have warnings.

@hczhu-db hczhu-db force-pushed the improve-query-error-msg branch from 0efb6c1 to 661e474 Compare November 1, 2024 04:54
@hczhu-db hczhu-db force-pushed the improve-query-error-msg branch from 661e474 to 9128246 Compare November 1, 2024 05:00
Copy link
Collaborator

@jnyi jnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious we only give 1 store grpc DNS, how does querier know its replication_factor is 2?

@hczhu-db hczhu-db merged commit 56cfce8 into db_main Nov 1, 2024
14 checks passed
@jnyi jnyi deleted the improve-query-error-msg branch November 1, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants