Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Intervals - make_disjoint and __init__ #351

Merged
merged 22 commits into from
Jan 23, 2024

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Jul 20, 2023

closes issue #268 and #299

Enhancements to make_disjoint to handle the recursive nature of making intervals disjoint as new intervals are being added to the set of already disjoint intervals.

Enhancements to __init__ of Intervals class to allow more flexibility in types accepted for series_ids

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ed1b77f) 87.60% compared to head (eb2451f) 87.97%.

Files Patch % Lines
python/tempo/intervals.py 93.58% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   87.60%   87.97%   +0.37%     
==========================================
  Files           6        6              
  Lines         871      998     +127     
  Branches      180      232      +52     
==========================================
+ Hits          763      878     +115     
- Misses         81       87       +6     
- Partials       27       33       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@R7L208 R7L208 changed the title Enhancements to Intervals - make_disjoint and __init__ [DRAFT] Enhancements to Intervals - make_disjoint and __init__ Jul 26, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@tnixon tnixon marked this pull request as draft January 16, 2024 23:53
…sjoint

# Conflicts:
#	python/tempo/tsdf.py
@R7L208 R7L208 marked this pull request as ready for review January 23, 2024 00:16
@R7L208 R7L208 changed the title [DRAFT] Enhancements to Intervals - make_disjoint and __init__ Enhancements to Intervals - make_disjoint and __init__ Jan 23, 2024
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!

@tnixon tnixon merged commit 78e4171 into master Jan 23, 2024
14 checks passed
@tnixon tnixon deleted the issue268-enhance-disjoint branch January 23, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants