-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to Intervals - make_disjoint and __init__ #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- integrate new make_disjoint code with project - update unit_tests and test data
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 87.60% 87.97% +0.37%
==========================================
Files 6 6
Lines 871 998 +127
Branches 180 232 +52
==========================================
+ Hits 763 878 +115
- Misses 81 87 +6
- Partials 27 33 +6 ☔ View full report in Codecov by Sentry. |
R7L208
changed the title
Enhancements to Intervals - make_disjoint and __init__
[DRAFT] Enhancements to Intervals - make_disjoint and __init__
Jul 26, 2023
…sjoint # Conflicts: # python/tempo/tsdf.py
R7L208
changed the title
[DRAFT] Enhancements to Intervals - make_disjoint and __init__
Enhancements to Intervals - make_disjoint and __init__
Jan 23, 2024
tnixon
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #268 and #299
Enhancements to
make_disjoint
to handle the recursive nature of making intervals disjoint as new intervals are being added to the set of already disjoint intervals.Enhancements to
__init__
of Intervals class to allow more flexibility in types accepted forseries_ids