Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api-reference docs compile #374

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

josh-melton-db
Copy link
Contributor

Rebuilt from a new folder, docs now compile without warnings or errors after navigating to the docs folder and running make clean and make html

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like some of the linters are failing. Maybe you introduced some changes that are causing errors? Please try to get your code to pass Black & Flake8 checks.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d572233) 87.65% compared to head (2601513) 87.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   87.65%   87.60%   -0.06%     
==========================================
  Files           6        6              
  Lines         875      871       -4     
  Branches      181      180       -1     
==========================================
- Hits          767      763       -4     
  Misses         81       81              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josh-melton-db josh-melton-db requested a review from tnixon January 18, 2024 00:10
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's do this!

@tnixon tnixon merged commit ed1b77f into databrickslabs:master Jan 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants