Remove hidden bugs from unit tests by enforcing mocks #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
reviewed
Apr 26, 2024
| @@ -130,9 +126,10 @@ def test_create_external_locations(mock_ws, installation_multiple_roles, mock_aw | |||
| call(mock.ANY, 's3://BUCKETX/FOLDERX', 'credx', skip_validation=True), | |||
| ] | |||
| mock_ws.external_locations.create.assert_has_calls(calls, any_order=True) | |||
| aws.get_role_policy.assert_not_called() | |||
There was a problem hiding this comment.
this should still work, without re-adding aws = create_autospec(AWSResources)
Suggested change
| aws.get_role_policy.assert_not_called() | |
| mock_aws.get_role_policy.assert_not_called() |
There was a problem hiding this comment.
mock_aws was a bit difficult to read
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 88.78% 88.83% +0.04%
==========================================
Files 80 80
Lines 9980 9985 +5
Branches 1777 1778 +1
==========================================
+ Hits 8861 8870 +9
+ Misses 743 741 -2
+ Partials 376 374 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce check defined in: