Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #339 to correct contributing links #343

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

cpauvert
Copy link
Contributor

@cpauvert cpauvert commented Jul 4, 2023

Fixes #339

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@cpauvert
Copy link
Contributor Author

cpauvert commented Jul 4, 2023

I'm sorry, the a3d0dae commit was reverted as it is safer belonging in a different PR (#342 ), in case the maintainers do not agree with the proposed changes.
This could be squashed on my side.
BEst,

Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @cpauvert !

@p-j-smith
Copy link
Contributor

Before I merge, please could you edit the comment at the top of this PR to say 'Fixes #339' - this way the issue will automatically be closed when the pr is merged. Thanks!

I'm sorry, the a3d0dae commit was reverted as it is safer belonging in a different PR (#342 ), in case the maintainers do not agree with the proposed changes.
This could be squashed on my side.
BEst,

And no worries about this, I can squash when merging the PR

@cpauvert
Copy link
Contributor Author

cpauvert commented Aug 14, 2023

Before I merge, please could you edit the comment at the top of this PR to say 'Fixes #339' - this way the issue will automatically be closed when the pr is merged. Thanks!

Done!

And no worries about this, I can squash when merging the PR

True! Good idea!
Thanks

@p-j-smith p-j-smith merged commit aafd9d0 into datacarpentry:main Aug 14, 2023
@p-j-smith
Copy link
Contributor

thanks @cpauvert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links need to be fixed in CONTRIBUTING.md
2 participants