Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the default doi sorting parameter #910

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Nov 13, 2024

Explicitly sets the default doi sorting parameter, previously this was implicitly set by passing a null or blank sort parameter to the REST API.

This is important if we ever want to change the default sorting parameter (such as in datacite/lupo/pull/1272)

Approach

Sets the default to '-updated' instead of null in relevant controllers/routes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested review from svogt0511, codycooperross and a team November 13, 2024 21:04
@jrhoads jrhoads merged commit e37f70f into main Nov 14, 2024
5 checks passed
@jrhoads jrhoads deleted the sort-defaults branch November 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants