Add pandas helper functions for get_stat_* #144

tjann · 2020-08-24T05:25:02Z

No description provided.

…pd input function.

…tly double quoted.

setup_dcpandas.py

requirements.txt

dcpandas/CHANGELOG.md

dcpandas/README.md

dcpandas/df_builder.py

beets

I have some meta questions around how we're structuring this library, as well as whether we should do the selection to cover most geos in this library or in the mixer (my vote for the latter, so that we get standardized behavior across clients).

dcpandas/CHANGELOG.md

dcpandas/README.md

dcpandas/df_builder.py

dcpandas/examples/df_builder.py

dcpandas/setup.py

dcpandas/README.md

…oolean.

…ll_by_obs_options.

…cpandas to datacommons_pandas.

beets

thanks, agree with the meta-changes you outlined. some outstanding comments still in df_builder.py

dcpandas/df_builder.py

…s_options.

…s-funcs

… get_stat_series.

datacommons/__init__.py

datacommons_pandas/CHANGELOG.md

datacommons_pandas/core.py

datacommons_pandas/examples/df_builder.py

shifucun · 2020-08-25T16:21:51Z

The structure looks much cleaner now!

…log.

datacommons/__init__.py

datacommons_pandas/README.md

datacommons_pandas/__init__.py

dcpandas/README.md

beets

thanks for the investigation, i think this solution works well!

i still have some unaddressed comments on df_builder.py (they seem to have gotten collapsed). could you take a look at those? mostly around readability and reusability of the selection logic.

…lder; add test for raising no data error; fix various tests that were returning the type HTTPError instead of an instance of HTTPError.

beets

thanks for making all the changes!

tjann added 13 commits August 23, 2020 13:33

Add pandas wrapper function for time series data frame.

e05e404

Save work so far on pandas.

2f070fd

Minor edits.

b1feeca

Add function for creating covariate pandas df.

516033b

Add latest date sorting to covariate as well. Add test for covariate …

529aeb3

…pd input function.

stat_vars_test: make response and expected response strings consisten…

a7868e2

…tly double quoted.

Add an example for covariate_pd_input

ea3c2ff

Make stat_var examples quoting consistent.

ab3f755

Create dcpandas module that uses pandas natively.

e72ae4a

Do the python release in another PR.

32a0284

Remove stale refs in datacommons library to pandas features.

160eee6

Update pandas readme.

771b0a5

Cleanup format.

5a86466

tjann requested a review from shifucun August 24, 2020 09:20

tjann marked this pull request as ready for review August 24, 2020 09:20

tjann added 2 commits August 24, 2020 02:47

Remove pd-related mocks from python testing.

5780970

Cosmetics.

cb83487

tjann requested review from pradh and beets August 24, 2020 10:26

tjann added 3 commits August 24, 2020 03:28

Update docstring

85b3a9b

Fix import statement for pip. Always sort time series df columns.

4044c03

Restore pandas setup to prepare for release.

d6290be

shifucun reviewed Aug 24, 2020

View reviewed changes

beets reviewed Aug 24, 2020

View reviewed changes

tjann added 5 commits August 24, 2020 13:40

change _group_stat_all_by_obs_options mode parameter to time_series b…

4bba808

…oolean.

Address some documentation suggestions from cyin.

c81eaa6

Fix bug from reassigning parameter time_series value in _group_stat_a…

d3a618d

…ll_by_obs_options.

Make df_builder examples more readable.

a4bcf4e

Update the docstrings for both PyPI release setup*.py files. Change d…

a2202c0

…cpandas to datacommons_pandas.

beets reviewed Aug 24, 2020

View reviewed changes

dcpandas/df_builder.py Outdated Show resolved Hide resolved

tjann added 5 commits August 24, 2020 15:52

Rename time_series parameter to keep_series for _group_stat_all_by_ob…

0ebb20f

…s_options.

dcpandas to datacommons_pandas, including all datacommons functions

efd2e0c

Fix various docstrings.

f645f3f

Merge branch 'master' into pandas-funcs

1ea347d

Merge branch 'pandas-funcs' of github.com:tjann/api-python into panda…

5454a93

…s-funcs

tjann requested review from shifucun and beets August 25, 2020 05:54

tjann added 2 commits August 25, 2020 07:54

Add optional args to pandas lib build_time_series to pass onto python…

18cb93e

… get_stat_series.

Update docstrings for time series funcs.

51582c8

shifucun reviewed Aug 25, 2020

View reviewed changes

datacommons/__init__.py Show resolved Hide resolved

shifucun reviewed Aug 25, 2020

View reviewed changes

datacommons_pandas/CHANGELOG.md Show resolved Hide resolved

shifucun reviewed Aug 25, 2020

View reviewed changes

datacommons_pandas/CHANGELOG.md Outdated Show resolved Hide resolved

datacommons_pandas/CHANGELOG.md Outdated Show resolved Hide resolved

datacommons_pandas/core.py Show resolved Hide resolved

datacommons_pandas/examples/df_builder.py Show resolved Hide resolved

tjann added 2 commits August 25, 2020 09:33

Remove will from CHANGELOG.

a49a095

Reference TODO for cloudbuild pandas-python sync check. Update change…

7f46fdd

…log.

tjann requested a review from shifucun August 25, 2020 16:43

shifucun approved these changes Aug 25, 2020

View reviewed changes

beets reviewed Aug 25, 2020

View reviewed changes

datacommons/__init__.py Outdated Show resolved Hide resolved

datacommons/__init__.py Show resolved Hide resolved

datacommons_pandas/README.md Show resolved Hide resolved

datacommons_pandas/__init__.py Outdated Show resolved Hide resolved

dcpandas/README.md Outdated Show resolved Hide resolved

beets reviewed Aug 25, 2020

View reviewed changes

tjann added 2 commits August 25, 2020 12:50

Rename covariate* to multivariate*, address cyin's comments on df_bui…

87b13ec

…lder; add test for raising no data error; fix various tests that were returning the type HTTPError instead of an instance of HTTPError.

Update docstring for _group_stat_all_by_obs_options.

f116e42

beets approved these changes Aug 25, 2020

View reviewed changes

tjann added 3 commits August 25, 2020 15:20

Make err msg for _group_stat_all_by_obs_options no data more general.

975c956

Parameterize some pandas lib example functions.

9865e09

Released pandas.

14dea40

tjann merged commit ffba5fd into datacommonsorg:master Aug 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pandas helper functions for get_stat_* #144

Add pandas helper functions for get_stat_* #144

tjann commented Aug 24, 2020

beets left a comment

beets left a comment

shifucun commented Aug 25, 2020

beets left a comment

beets left a comment

Add pandas helper functions for get_stat_* #144

Add pandas helper functions for get_stat_* #144

Conversation

tjann commented Aug 24, 2020

beets left a comment

Choose a reason for hiding this comment

beets left a comment

Choose a reason for hiding this comment

shifucun commented Aug 25, 2020

beets left a comment

Choose a reason for hiding this comment

beets left a comment

Choose a reason for hiding this comment