Added a synchronous interface to the HttpClient #166
Conversation
| { | ||
| return [=](const HttpRequest&, HttpClientError error, int statusCode, | ||
| std::string&& headers, std::string&& body) { | ||
| if (error != HttpClientError::None) { |
There was a problem hiding this comment.
Si une erreur est retournee, elle doit faire partie de la reponse retournee ou lancer une exception. Ici elle est simplement ignoree, ce qui est dangereux.
There was a problem hiding this comment.
Right, I didn't know what do to with that since HttpResponse does not contain any errorCode field. I didn't want to add this field in the class directly because the class is used for server-side code (HttpEndpoint).
So I guess throwing an exception will do for now ?
There was a problem hiding this comment.
Right, I didn't know what do to with that since HttpResponse does not
contain any errorCode field. I didn't want to add this field in the
class directly because the class is used for server-side code
(HttpEndpoint).So I guess throwing an exception will do for now ?
What matters here is to have a behaviour that would be compatible with
the one from HttpRestProxy. But on the other hand, I think the passing
of error codes enables better practices with regards to error handling.
I would thus improve HttpResponse with an HttpClientError member instead.
…en HttpRestProxy and HttpClient
|
-1 for now. We should make use of EpollLoop::loop in order to ensure that operations have been completed, instead of a distinct msg loop thread. |
No description provided.