#1306 Remove unneeded logging level configuration in BaseFakerTest.be…

…fore()

It was WTF moment when I realized that method BaseFakerTest.before() resets all logger levels to INFO.
It took few hours to find out why my logging configuration doesn't work. :(

src/main/java/net/datafaker/providers/base/Twitter.java

@@ -8,7 +8,6 @@
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.UUID;
-import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -58,7 +57,6 @@ public Date createdTime(boolean forward, Date base, Date constraints) {
      */
     public String twitterId(int expectedLength) {
         if (expectedLength <= 6 || expectedLength >= 25) {
-            LOGGER.setLevel(Level.WARNING);
             LOGGER.warning("expectedLength <= 6 may easily cause twitter id collision. And expectedLength >= 25" +
                 " can be easily out of bound.");
         }

src/test/java/net/datafaker/providers/base/BaseFakerTest.java

@@ -15,9 +15,7 @@
 import java.util.List;
 import java.util.Set;
 import java.util.function.Supplier;
-import java.util.logging.Handler;
 import java.util.logging.Level;
-import java.util.logging.LogManager;
 import java.util.logging.Logger;
 import java.util.regex.Pattern;
 
@@ -39,17 +37,11 @@ public class BaseFakerTest<T extends BaseFaker> {
     protected final T faker = getFaker();
 
     @BeforeEach
-    protected void before() {
+    @SuppressWarnings("EmptyTryBlock")
+    final void resetMocks() throws Exception {
         try (AutoCloseable ignored = MockitoAnnotations.openMocks(this)) {
-
-            Logger rootLogger = LogManager.getLogManager().getLogger("");
-            Handler[] handlers = rootLogger.getHandlers();
-            rootLogger.setLevel(Level.INFO);
-            for (Handler h : handlers) {
-                h.setLevel(Level.INFO);
-            }
-        } catch (Exception e) {
-            throw new RuntimeException(e);
+            // Need to reset all @Spy and @Mock fields
+            // because all test methods share the same test class instance due to @TestInstance(PER_CLASS)
         }
     }
 

src/test/java/net/datafaker/providers/base/RandomFakerTest.java

@@ -14,8 +14,7 @@ class RandomFakerTest extends BaseFakerTest<BaseFaker> {
     private Random random;
 
     @BeforeEach
-    protected void before() {
-        super.before();
+    final void before() {
         random = new Random();
         faker = new BaseFaker(random);
     }

src/test/java/net/datafaker/providers/foods/HebrewFoodTest.java

@@ -15,7 +15,7 @@ class HebrewFoodTest extends FoodFakerTest {
     private Food food = getFaker().food();
 
     @BeforeEach
-    protected void before() {
+    final void before() {
         food = getFaker().food();
     }
 

src/test/java/net/datafaker/service/FakeValuesServiceTest.java

@@ -53,19 +53,16 @@ class FakeValuesServiceTest extends AbstractFakerTest {
     @Mock
     private RandomService randomService;
 
+    @Spy
     private FakeValuesService fakeValuesService;
     private FakerContext context;
 
     @BeforeEach
-    protected void before() {
-        super.before();
-
+    final void before() {
         // always return the first element
         when(randomService.nextInt(anyInt())).thenReturn(0);
         context = new FakerContext(new Locale("test"), randomService);
         when(mockedFaker.getContext()).thenReturn(context);
-
-        fakeValuesService = Mockito.spy(new FakeValuesService());
         fakeValuesService.updateFakeValuesInterfaceMap(context.getLocaleChain());
     }