Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Namespacing CLI options #860

Closed
wants to merge 19 commits into from
Closed

Namespacing CLI options #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cdfbed8
namespacing cli options
sar009 Jan 25, 2024
645a0ed
fixing unit test
sar009 Jan 25, 2024
3012174
fixing test
sar009 Jan 25, 2024
5ab1995
fixing unit test
sar009 Jan 25, 2024
f4df144
Merge branch 'master' into 859
sar009 Feb 5, 2024
3b0b7cc
Merge branch 'master' into 859
sar009 Feb 7, 2024
8802e1b
Update data_diff/config.py
sar009 Feb 8, 2024
bd075c5
Merge branch 'master' into 859
sar009 Feb 8, 2024
965ead0
adding pydantic
sar009 Feb 8, 2024
e84b510
update poetry lock
sar009 Feb 8, 2024
a955877
fixing test
sar009 Feb 8, 2024
2b5093d
minor
sar009 Feb 8, 2024
401b6fb
fixing unit test
sar009 Feb 20, 2024
7d63162
fixing unit test
sar009 Feb 20, 2024
12a3216
fixing unit test
sar009 Feb 20, 2024
c02b32c
fixing unit test
sar009 Feb 20, 2024
7c7f72a
minor
sar009 Feb 20, 2024
c7822ce
Merge branch 'master' into 859
sar009 Feb 21, 2024
b85d8a3
Merge branch 'master' into 859
sar009 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_diff/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
def connect_to_table(
db_info: Union[str, dict],
table_name: Union[DbPath, str],
key_columns: str = ("id",),
key_columns: Tuple[str] = ("id",),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch. You're reminding me that we need to add static type checking to this codebase

thread_count: Optional[int] = 1,
**kwargs,
) -> TableSegment:
Expand Down
Loading
Loading