Skip to content

feat: some steps to make iceberg work #79

feat: some steps to make iceberg work

feat: some steps to make iceberg work #79

GitHub Actions / clippy failed Apr 23, 2024 in 1s

clippy

28 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 28
Warning 0
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check failure on line 260 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

error: the borrowed expression implements the required traits
   --> src/catalog_provider/glue.rs:260:32
    |
260 | ...   let path = Path::parse(&strip_prefix(metadata_location)).map_err(|_| GlueError::Other(format!("Failed to parse {} as path", metadat...
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `strip_prefix(metadata_location)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

Check failure on line 259 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

error: useless use of `format!`
   --> src/catalog_provider/glue.rs:259:96
    |
259 | ...ion").ok_or(GlueError::AWS(format!("Did not find metadata_location property in glue catalog")))?;
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Did not find metadata_location property in glue catalog".to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `-D clippy::useless-format` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`

Check failure on line 260 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

error: the borrowed expression implements the required traits
   --> src/catalog_provider/glue.rs:260:32
    |
260 | ...   let path = Path::parse(&strip_prefix(metadata_location)).map_err(|_| GlueError::Other(format!("Failed to parse {} as path", metadat...
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `strip_prefix(metadata_location)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

Check failure on line 259 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

error: useless use of `format!`
   --> src/catalog_provider/glue.rs:259:96
    |
259 | ...ion").ok_or(GlueError::AWS(format!("Did not find metadata_location property in glue catalog")))?;
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Did not find metadata_location property in glue catalog".to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `-D clippy::useless-format` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`

Check failure on line 248 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `sd`

error: unused variable: `sd`
   --> src/catalog_provider/glue.rs:248:9
    |
248 |         sd: &StorageDescriptor,
    |         ^^ help: if this is intentional, prefix it with an underscore: `_sd`

Check failure on line 248 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `sd`

error: unused variable: `sd`
   --> src/catalog_provider/glue.rs:248:9
    |
248 |         sd: &StorageDescriptor,
    |         ^^ help: if this is intentional, prefix it with an underscore: `_sd`

Check failure on line 247 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `table_name`

error: unused variable: `table_name`
   --> src/catalog_provider/glue.rs:247:9
    |
247 |         table_name: &str,
    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_name`

Check failure on line 247 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `table_name`

error: unused variable: `table_name`
   --> src/catalog_provider/glue.rs:247:9
    |
247 |         table_name: &str,
    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_name`

Check failure on line 246 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `database_name`

error: unused variable: `database_name`
   --> src/catalog_provider/glue.rs:246:9
    |
246 |         database_name: &str,
    |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_database_name`

Check failure on line 246 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `database_name`

error: unused variable: `database_name`
   --> src/catalog_provider/glue.rs:246:9
    |
246 |         database_name: &str,
    |         ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_database_name`

Check failure on line 245 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

error: unused variable: `ctx`
   --> src/catalog_provider/glue.rs:245:9
    |
245 |         ctx: &SessionState,
    |         ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check failure on line 245 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

error: unused variable: `ctx`
   --> src/catalog_provider/glue.rs:245:9
    |
245 |         ctx: &SessionState,
    |         ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check failure on line 244 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `table_registration_options`

error: unused variable: `table_registration_options`
   --> src/catalog_provider/glue.rs:244:9
    |
244 |         table_registration_options: &TableRegistrationOptions,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_registration_options`

Check failure on line 244 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `table_registration_options`

error: unused variable: `table_registration_options`
   --> src/catalog_provider/glue.rs:244:9
    |
244 |         table_registration_options: &TableRegistrationOptions,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_registration_options`

Check failure on line 243 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `glue_table`

error: unused variable: `glue_table`
   --> src/catalog_provider/glue.rs:243:9
    |
243 |         glue_table: &Table,
    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_glue_table`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 243 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `glue_table`

error: unused variable: `glue_table`
   --> src/catalog_provider/glue.rs:243:9
    |
243 |         glue_table: &Table,
    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_glue_table`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 31 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::util`

error: unused import: `iceberg_rust::util`
  --> src/catalog_provider/glue.rs:31:5
   |
31 | use iceberg_rust::util;
   |     ^^^^^^^^^^^^^^^^^^

Check failure on line 30 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::table::table_builder::TableBuilder`

error: unused import: `iceberg_rust::table::table_builder::TableBuilder`
  --> src/catalog_provider/glue.rs:30:5
   |
30 | use iceberg_rust::table::table_builder::TableBuilder;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 28 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::error::Error::TableMetadataBuilder`

error: unused import: `iceberg_rust::error::Error::TableMetadataBuilder`
  --> src/catalog_provider/glue.rs:28:5
   |
28 | use iceberg_rust::error::Error::TableMetadataBuilder;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 27 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::catalog::Catalog`

error: unused import: `iceberg_rust::catalog::Catalog`
  --> src/catalog_provider/glue.rs:27:5
   |
27 | use iceberg_rust::catalog::Catalog;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 24 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `std::io::Cursor`

error: unused import: `std::io::Cursor`
  --> src/catalog_provider/glue.rs:24:5
   |
24 | use std::io::Cursor;
   |     ^^^^^^^^^^^^^^^

Check failure on line 5 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `aws_config::BehaviorVersion`

error: unused import: `aws_config::BehaviorVersion`
 --> src/catalog_provider/glue.rs:5:5
  |
5 | use aws_config::BehaviorVersion;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 31 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::util`

error: unused import: `iceberg_rust::util`
  --> src/catalog_provider/glue.rs:31:5
   |
31 | use iceberg_rust::util;
   |     ^^^^^^^^^^^^^^^^^^

Check failure on line 30 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::table::table_builder::TableBuilder`

error: unused import: `iceberg_rust::table::table_builder::TableBuilder`
  --> src/catalog_provider/glue.rs:30:5
   |
30 | use iceberg_rust::table::table_builder::TableBuilder;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 28 in src/catalog_provider/glue.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `iceberg_rust::error::Error::TableMetadataBuilder`

error: unused import: `iceberg_rust::error::Error::TableMetadataBuilder`
  --> src/catalog_provider/glue.rs:28:5
   |
28 | use iceberg_rust::error::Error::TableMetadataBuilder;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^