refactor: Bump arrow 52 and datafusion 39 (#105)

* refactor: Bump arrow 52 and datafusion 39 Signed-off-by: Xuanwo <[email protected]> * Fix union Signed-off-by: Xuanwo <[email protected]> * Format code Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
datafusion-contrib · Jul 1, 2024 · 05825ea · 05825ea
1 parent fb03b67
commit 05825ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/file_format.rs b/file_format.rs
@@ -6,7 +6,7 @@ use std::sync::Arc;
 use crate::reader::metadata::read_metadata_async;
 use arrow::datatypes::Schema;
 use datafusion::arrow::datatypes::SchemaRef;
-use datafusion::common::{FileType, Statistics};
+use datafusion::common::Statistics;
 use datafusion::datasource::file_format::FileFormat;
 use datafusion::datasource::physical_plan::FileScanConfig;
 use datafusion::error::Result;
@@ -97,10 +97,4 @@ impl FileFormat for OrcFormat {
     ) -> Result<Arc<dyn ExecutionPlan>> {
         Ok(Arc::new(OrcExec::new(conf)))
     }
-
-    // TODO: Doesn't seem important for now, but maybe change in DataFusion itself?
-    //       Add an Extension(name) variant maybe?
-    fn file_type(&self) -> FileType {
-        unimplemented!("Extension file type: ORC")
-    }
 }
diff --git a/physical_exec.rs b/physical_exec.rs
@@ -59,7 +59,7 @@ impl ExecutionPlan for OrcExec {
         self
     }
 
-    fn children(&self) -> Vec<Arc<dyn ExecutionPlan>> {
+    fn children(&self) -> Vec<&Arc<dyn ExecutionPlan>> {
         vec![]
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,7 +59,7 @@ impl ExecutionPlan for OrcExec { @@
             self
         }
-        fn children(&self) -> Vec<Arc<dyn ExecutionPlan>> {
+        fn children(&self) -> Vec<&Arc<dyn ExecutionPlan>> {
             vec![]
         }
@@ Expand Down @@