Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put async functionality behind feature #64

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Put async functionality behind feature #64

merged 1 commit into from
Mar 10, 2024

Conversation

progval
Copy link
Contributor

@progval progval commented Mar 10, 2024

Resolves #46

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 79.94%. Comparing base (424b021) to head (217d711).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   77.22%   79.94%   +2.71%     
==========================================
  Files          34       31       -3     
  Lines        3302     3121     -181     
==========================================
- Hits         2550     2495      -55     
+ Misses        752      626     -126

WenyXu
WenyXu approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu merged commit 73234be into datafusion-contrib:main Mar 10, 2024
9 checks passed
waynexia pushed a commit that referenced this pull request Oct 24, 2024
@progval
Put async functionality behind feature (#64)
fe5116e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put async functionality behind feature
2 participants
@progval @WenyXu