tests/integration/: Add support for decoding binaries #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 77.22% 80.52% +3.29%
==========================================
Files 34 30 -4
Lines 3302 3106 -196
==========================================
- Hits 2550 2501 -49
+ Misses 752 605 -147 |
Jefffrey
reviewed
Mar 14, 2024
Comment on lines
+71
to
+118
| fn binaries_to_uint8_list(batch: RecordBatch) -> RecordBatch { | ||
| RecordBatch::try_new( | ||
| Arc::new(Schema::new( | ||
| batch | ||
| .schema() | ||
| .fields | ||
| .into_iter() | ||
| .map(|field| { | ||
| Field::new( | ||
| field.name(), | ||
| match field.data_type() { | ||
| DataType::Binary => DataType::List(Arc::new(Field::new( | ||
| "value", | ||
| DataType::UInt8, | ||
| false, | ||
| ))), | ||
| DataType::LargeBinary => DataType::LargeList(Arc::new(Field::new( | ||
| "value", | ||
| DataType::UInt8, | ||
| false, | ||
| ))), | ||
| data_type => data_type.clone(), | ||
| }, | ||
| field.is_nullable(), | ||
| ) | ||
| }) | ||
| .collect::<Vec<_>>(), | ||
| )), | ||
| batch | ||
| .columns() | ||
| .iter() | ||
| .map(|array| match array.as_binary_opt() { | ||
| Some(array) => { | ||
| let (offsets, values, nulls) = array.clone().into_parts(); | ||
| ListArray::try_new( | ||
| Arc::new(Field::new("value", DataType::UInt8, false)), | ||
| offsets, | ||
| Arc::new(PrimitiveArray::<UInt8Type>::new(values.into(), None)), | ||
| nulls, | ||
| ) | ||
| .map(Arc::new) | ||
| .expect("Could not create ListArray") | ||
| } | ||
| None => array.clone(), | ||
| }) | ||
| .collect(), | ||
| ) | ||
| .expect("Could not rebuild RecordBatch") |
There was a problem hiding this comment.
I wonder if there's a way to use cast kernels to achieve the same effect instead of recreating a new recordbatch 🤔
|
FYI will go with this approach #73 So won't have to muck about with JSON parsing |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes in the direction opposite to #66, but I already had the code so it doesn't hurt. (At worst it can be deleted when implementing #66)
Also fixes the comment on
decimal