Add lint tools to the project #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarMoya
force-pushed
the
add_lint_tools
branch
2 times, most recently
from
cfe3750 to
7a17910
Compare
msune
requested changes
Jun 6, 2024
Added two Makefile recipes in order to format the code and pass the linter and the type checker using autopep8 for formatting and mypy and flake for linting. This will ensure that all contributions to this project will follow the same rules and the code will be more traceble and easier to read and follow. As part of this PR there are some other minor fixes: * Removed `*` imports * Fixed some naming conventions * Fixed some Imports between SqlModel/SqlAlchemy objects * Added type returns to all the functions * Removed unused imports * Fix minor style issues Signed-off-by: Oscar Moya <[email protected]>
|
Thx a ton! merging 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two Makefile recipes in order to format the code and pass the linter and the type checker using autopep8 for formatting and mypy and flake for linting.
This will ensure that all contributions to this project will follow the same rules and the code will be more traceble and easier to read and follow.
As part of this PR there are some other minor fixes:
*imports