Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting GeoJSON #152

Open
gperonato opened this issue Nov 20, 2020 · 6 comments
Open

Supporting GeoJSON #152

gperonato opened this issue Nov 20, 2020 · 6 comments

Comments

@gperonato
Copy link
Contributor

Is GeoJSON support in the roadmap? Dumping to GeoJSON would be a nice feature to have for datasets containing geographic features

@gperonato
Copy link
Contributor Author

First attempt in #153

@akariv
Copy link
Member

akariv commented Nov 23, 2020

Great suggestion - let's work on that PR together.

@n0rdlicht
Copy link

As far as I can tell from the PR this helps writing out point based GeoJSONs. Did you think about also using MultiPoint / LineString / Polygon / MultiLineString / MultiPolygon geometry, which the spec currently doesn't account for except for wrapping it in a GeoJSON object per row.

@gperonato
Copy link
Contributor Author

gperonato commented Dec 9, 2020

Hi @n0rdlicht, indeed you would need a geojson object per row for including geometries other than geopoints. The current spec is based on the Frictionless table schema, which only supports geopoint and geojson. I think this is good to provide compatibility with CSV files, where you usually do not store complex geometries (or if you do, I think it's a good practice to include a geojson object). But indeed, it would be interesting to accept generic GeoJSON files (including then the geometry types you mentioned) as source files in the pipeline.

@n0rdlicht
Copy link

Hi @n0rdlicht, indeed you would need a geojson object per row for including geometries other than geopoints. The current spec is based on the Frictionless table schema, which only supports geopoint and geojson. I think this is good to provide compatibility with CSV files, where you usually do not store complex geometries (or if you do, I think it's a good practice to include a geojson object). But indeed, it would be interesting to accept generic GeoJSON files (including then the geometry types you mentioned) as source files in the pipeline.

Fully agree with this. What would be your thoughts on using WKT Strings as a second option?

@gperonato
Copy link
Contributor Author

Definitely a very good idea! But maybe this should be discussed before in the frictionless repositories/discord channel, and only subsequently integrated in dataflows and/or datapackage-pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants