Basic support to geojson

[gperonato]

Feature collection of points

[akariv]

Hey @gperonato - thanks for the PR!! I left a few comments and questions.

[akariv]

@gperonato lmk when you're ready for another review

[gperonato]

Ready, sorry for the multiple commits!

[akariv]

Hey, so a few things (apart from the CR fixes):

• Please include in your PR also the necessary modifications to documentation
• Please add a test for this new functionality
• Please rebase the branch to ensure you're based on the latest master branch

[akariv]

Some simplification and clarification comments

[akariv]

@gperonato lmk if you need any help in finalizing this... it's really close to the finish line :)

[gperonato]

Can you check the latest commit?

[n0rdlicht]

Super cool you have been working on this @gperonato 👍 . If we (also my colleagues at cividi, e.g. @loleg or @bkarolina) can help getting this done in any way, let us know.

[gperonato]

Super cool you have been working on this @gperonato 👍 . If we (also my colleagues at cividi, e.g. @loleg or @bkarolina) can help getting this done in any way, let us know.

Thank you, great to see there is some interest in this feature! Let's coordinate on #152, I think accepting a generic GeoJSON would be a nice add on, I haven't done any test on that

[akariv]

Thanks @gperonato!

I rebased the code to the latest master and did some cleanup, you can check it out in #155

[loleg]

Many thanks for this highly useful effort. A couple of thoughts/questions that could be converted to tickets from my side:

• GeoJSON is a subset of / extends JSON support, but by having to explicitly initialise it (rather than load as a separate module, let's say) it seems to be treated on par. Would we do the same for TSV? SQLite? GeoPackage? But I guess it's too early to worry about scalability when there are only 3 formats supported at this time.
• On this note, the introduction of default_serializer to file_formats.py might warrant it's own PR, or at least a check through the other code and documentation.
• What about auto-detecting a GeoJSON file?
• We should link to RFC 7946 or similar. To me this effort is also closely related to the effort to create a Geo Data Package. Currently the README doesn't really cover file format support, but it should.
• We might want to stick to a .geojson file extension in the example, though make it clear that this is not required.
• Where does validation happen? I.e. where would you hand off to a more specialized library like python-geojson.
• What about streaming support, e.g. would dataflows handle use cases similar to https://github.com/4xle/geojson-vt-stream ?
• It would be very helpful to add a section to the Tutorial

[akariv]

Closing in favor of #174