Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): All View generation when queries_v2 is turned off #12181

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix(ingest/bigquery): All View generation when queries_v2 is turned off #12181

wants to merge 9 commits into from

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 19, 2024
@hsheth2 hsheth2 requested a review from mayurinehate December 19, 2024 19:26
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-768-allow-view-lineage branch 2 times, most recently from 90238b3 to 804003b Compare December 20, 2024 07:43
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review December 20, 2024 07:44
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 20, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-768-allow-view-lineage branch from 804003b to cfe996d Compare December 20, 2024 07:51
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-768-allow-view-lineage branch from 0699bd9 to 9ad1574 Compare December 27, 2024 09:40
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 27, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the fix/ING-768-allow-view-lineage branch from abbb8ae to d700bc3 Compare December 27, 2024 13:26
mayurinehate
mayurinehate reviewed Dec 30, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema_gen.py
self.view_definitions[table_ref] = view.view_definition
table_ref = str(BigQueryTableRef(table_identifier).get_sanitized_table_ref())
self.table_refs.add(table_ref)
if self.config.lineage_parse_view_ddl and view.view_definition:
Copy link
Collaborator

@mayurinehate mayurinehate Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove lineage_parse_view_ddl from config

mayurinehate
mayurinehate reviewed Dec 30, 2024
View reviewed changes
metadata-ingestion/tests/integration/bigquery_v2/test_bigquery.py
(True, True, False, "bigquery_mcp_lineage_golden_2.json"),
(False, False, True, "bigquery_mcp_lineage_golden_3.json"),
(False, True, True, "bigquery_mcp_lineage_golden_4.json"),
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use same file if bigquery_mcp_lineage_golden_1.json and bigquery_mcp_lineage_golden_2.json are exactly same ?

Also if bigquery_mcp_lineage_golden_3 and bigquery_mcp_lineage_golden_4.json are exactly same, which I'm guessing they will be.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar-salvi-apptware @mayurinehate