-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): further consolidate NODE_OPTIONS #12217
Merged
david-leifker
merged 8 commits into
datahub-project:master
from
david-leifker:node-options-consilidation
Dec 31, 2024
Merged
fix(ci): further consolidate NODE_OPTIONS #12217
david-leifker
merged 8 commits into
datahub-project:master
from
david-leifker:node-options-consilidation
Dec 31, 2024
+147
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
labels
Dec 23, 2024
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Dec 23, 2024
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 00:15
985476a
to
44566ab
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 00:46
44566ab
to
2390b28
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 01:11
2390b28
to
79088ac
Compare
hsheth2
approved these changes
Dec 24, 2024
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 01:16
79088ac
to
dc0d6bb
Compare
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 24, 2024
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 01:59
dc0d6bb
to
a80d6a5
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
December 24, 2024 02:02
a80d6a5
to
f1eaba6
Compare
chakru-r
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
pending-submitter-merge
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent having to track down and modify memory settings in multiple places for NODE_OPTIONS
@chakru-r when trying to enable coverage, I think we're missing tests? Disabling for now.
Checklist