Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/sql-common): sql_common to use SqlParsingAggregator #12220

Merged
merged 14 commits into from
Dec 29, 2024
Merged

fix(ingest/sql-common): sql_common to use SqlParsingAggregator #12220

merged 14 commits into from
Dec 29, 2024

Conversation

sagar-salvi-apptware
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 24, 2024
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the refactor/ING-779-sql_common_sqlparsingaggregator branch from 4631f81 to 3814a60 Compare December 24, 2024 08:29
@sagar-salvi-apptware sagar-salvi-apptware force-pushed the refactor/ING-779-sql_common_sqlparsingaggregator branch from a34419e to b83b456 Compare December 27, 2024 06:11
@sagar-salvi-apptware sagar-salvi-apptware marked this pull request as ready for review December 27, 2024 08:50
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 27, 2024
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
@anshbansal anshbansal merged commit b79857f into datahub-project:master Dec 29, 2024
121 of 137 checks passed
@hsheth2 hsheth2 mentioned this pull request Dec 30, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagar-salvi-apptware @mayurinehate @anshbansal