Fix(UI): Move setUpdatedName call inside updateName promise in Dataset name edit #12232
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
datahub-cyborg
bot
added
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why?
Currently, when a user edits the dataset name, the UI is updated immediately to reflect the new name, even if the underlying updateName promise fails. This is because the setUpdatedName call is outside of the promise, meaning it runs regardless of the promise result, leading to a mismatch between the UI state and the actual dataset name. So, Moved the setUpdatedName call inside the updateName promise's .then() block to ensure that the UI is only updated when the name change operation is successful. This ensures that the dataset name in the UI matches the actual name after a successful update, preventing the UI from prematurely showing an updated name when the operation fails.