Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tableau): set ingestion stage report and pertimers #12234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(tableau): set ingestion stage report and pertimers #12234

wants to merge 4 commits into from
+105 −14

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 27, 2024 •
edited
Loading

Locally tested:

...
{'ingestion_stage': 'End at 2024-12-27 12:56:56.379116+00:00',
 'ingestion_stage_durations': {'Ingesting Tableau Site: 9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c acryldatatableaupartnershipportal at 2024-12-27 12:55:43.160127+00:00': 73.22},
...

 'extract_usage_stats_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 0.39},
 'fetch_groups_timer': {},
 'populate_database_server_hostname_map_timer': {},
 'populate_projects_registry_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 1.51},
 'emit_workbooks_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 12.25},
 'emit_sheets_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 4.59},
 'emit_dashboards_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 1.42},
 'emit_embedded_datasources_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 38.28},
 'emit_published_datasources_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 9.37},
 'emit_custom_sql_datasources_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 0.49},
 'emit_upstream_tables_timer': {'9f087e55-dc7b-42cb-a5cb-08fd1b2f9e2c': 1.82},

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 27, 2024
@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 27, 2024 12:58
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 27, 2024
hsheth2
hsheth2 reviewed Dec 27, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
emit_custom_sql_datasources_timer: Dict[str, float] = dataclass_field(
default_factory=TopKDict
)
emit_upstream_tables_timer: Dict[str, float] = dataclass_field(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge fan of this - does it make sense to have a SiteReport type, and then the TableauSourceReport has a dict[str (site id), SiteReport]?

how many sites are there reasonably going to be? the main limitation is that we don't want the report size to grow in an unbounded way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually maybe this is ok - we really only care about the ones that take a long time, right

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 27, 2024
hsheth2
hsheth2 reviewed Dec 27, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
yield from self.emit_dashboards()
with PerfTimer() as timer:
yield from self.emit_dashboards()
self.report.emit_dashboards_timer[self.site_id] = round(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfTimer objects can go directly into the report, and will get automatically formatted nicely - it implements as_obj, which is used here

datahub/metadata-ingestion/src/datahub/ingestion/api/report.py

Line 41 in 2e14f70

if isinstance(some_val, SupportsAsObj):

so we could do something like with self.report.emit_dashboards_timer.setdefault(self.site_id, PerfTimer()):

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although we might need to make some tweaks to TopKDict to make that work, so may not be worth it

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
@@ -3457,33 +3493,88 @@ def _create_workbook_properties(
return {"permissions": json.dumps(groups)} if len(groups) > 0 else None

def ingest_tableau_site(self):
self.report.report_ingestion_stage_start(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually I want to make these stages context managers - explicitly reporting start/end feels pretty error-prone

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
emit_custom_sql_datasources_timer: Dict[str, float] = dataclass_field(
default_factory=TopKDict
)
emit_upstream_tables_timer: Dict[str, float] = dataclass_field(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually maybe this is ok - we really only care about the ones that take a long time, right

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
self._fetch_groups()
with PerfTimer() as timer:
self._fetch_groups()
self.report.fetch_groups_timer[self.site_id] = round(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nicer to have site names in here instead of site ids, assuming they're unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

@anshbansal anshbansal Awaiting requested review from anshbansal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @hsheth2