-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/s3): add table filtering #12661
base: master
Are you sure you want to change the base?
feat(ingest/s3): add table filtering #12661
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
5037d74
to
d4637d6
Compare
d4637d6
to
9371c27
Compare
9371c27
to
9f91d21
Compare
@@ -145,6 +145,11 @@ class Config: | |||
description="Include hidden folders in the traversal (folders starting with . or _", | |||
) | |||
|
|||
allowed_tables: Optional[List[str]] = Field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other sources usually handle this filtering with the allow/deny patterns. So this should be:
tables_pattern: AllowDenyPattern = Field(
You can find many examples in the code https://github.com/search?q=repo%3Adatahub-project%2Fdatahub+AllowDenyPattern+language%3APython&type=code&l=Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Could you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on the new config parameter, so it is aligned with other sources
9f91d21
to
ed27f0b
Compare
52a1c37
to
10d7da5
Compare
Changes
|
10d7da5
to
e9ab564
Compare
- add tables_pattern to path_spec - add table filtering to S3Source().s3_browser()
e9ab564
to
024d22b
Compare
024d22b
to
22869f4
Compare
22869f4
to
024d22b
Compare
The CI ( |
Description
s3_source
trying ingest all folders inpath_spec.include
and this noisily triggers the warning messages.ignore_patterns
property, it is not a proper way because it will be wordy.Checklist