Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): handle noop mcl #12713

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Feb 23, 2025

Handle expected tracing output when no change to record template AND the trace id matches. The difference is that in this case the downstream storage change in ES is also an expected NO_OP.

Also prevent duplicate equality checks when determining the no op state.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 23, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...m/linkedin/metadata/utils/SystemMetadataUtils.java 90.90% <100.00%> (+76.62%) ⬆️
...n/java/com/linkedin/metadata/entity/AspectDao.java 96.07% <100.00%> (+0.16%) ⬆️
...om/linkedin/metadata/entity/EntityServiceImpl.java 79.96% <100.00%> (+0.24%) ⬆️
.../com/linkedin/metadata/trace/TraceServiceImpl.java 85.47% <100.00%> (+1.15%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ef1ac...19df5c0. Read the comment docs.

* handle expected tracing output when no change to record template
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 24, 2025
@david-leifker david-leifker merged commit 005a9b0 into datahub-project:master Feb 24, 2025
196 of 197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants