Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose role kwarg within SingleOutputRecipeCreator.with_output() and SingleOutputRecipeCreator.with_existing_output() #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose role kwarg within SingleOutputRecipeCreator.with_output() and SingleOutputRecipeCreator.with_existing_output() #273

wants to merge 1 commit into from

Conversation

jonbannister
Copy link

@jonbannister jonbannister commented Dec 13, 2022 •
edited
Loading

No description provided.

@jonbannister
Expose role kwarg within SingleOutputRecipeCreator.with_output() and …
4b3ec6b 
…SingleOutputRecipeCreator.with_existing_output()
jonbannister
jonbannister commented Dec 13, 2022
View reviewed changes
Copy link
Author

@jonbannister jonbannister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent users of the API from having to use the private method to provide a role for the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonbannister