-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adaptative time range pagination [sc-159069] #33
Conversation
This pull request has been linked to Shortcut Story #159069: [OSIsoft plugin] Adapt time range on 400 errors. |
…nto feature/sc-159069-no-more-maxcount
…eature/sc-159069-no-more-maxcount
…067-add-summary-type-selector
…c-188829-pi-time-expression-value-drift
Fixed on upstream branch here |
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…e-search-connector' into fix/comments-for-1-2-2
…e-search-connector' into fix/comments-for-1-2-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
Thanks for all those changes to clarify things, it will make a big difference when other people look at this.
I note that before merging we of course have to merge in the upstream branches, including fix/comments-for-1-2-2
where the review changes were made.
Fix/comments for 1 2 2
…nual-input-on-attribute-search-connector Feature/sc 190307 add template manual input on attribute search connector
…value-drift Bug/sc 188829 pi time expression value drift
…e-selector Feature/sc 175067 add summary type selector
Note: before merging we have to merge the upstream branches for 1.2.2 to this PR (after their reviews have passed), including
fix/comments-for-1-2-2
where the review changes were made for this PRStory details: https://app.shortcut.com/dataiku/story/159069