Add adaptative time range pagination [sc-159069] #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #159069: [OSIsoft plugin] Adapt time range on 400 errors. |
…nto feature/sc-159069-no-more-maxcount
…eature/sc-159069-no-more-maxcount
…067-add-summary-type-selector
…c-188829-pi-time-expression-value-drift
Fixed on upstream branch here |
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…e-search-connector' into fix/comments-for-1-2-2
…e-search-connector' into fix/comments-for-1-2-2
liamlynch-data
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM now 👍
Thanks for all those changes to clarify things, it will make a big difference when other people look at this.
I note that before merging we of course have to merge in the upstream branches, including fix/comments-for-1-2-2 where the review changes were made.
Merged
Fix/comments for 1 2 2
…nual-input-on-attribute-search-connector Feature/sc 190307 add template manual input on attribute search connector
…value-drift Bug/sc 188829 pi time expression value drift
…e-selector Feature/sc 175067 add summary type selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: before merging we have to merge the upstream branches for 1.2.2 to this PR (after their reviews have passed), including
fix/comments-for-1-2-2where the review changes were made for this PRStory details: https://app.shortcut.com/dataiku/story/159069