Feature/sc 175067 add summary type selector #40
Conversation
|
This pull request has been linked to Shortcut Story #175067: [OSIsoft plugin] For data type = summary, offer all available computation types. |
…067-add-summary-type-selector
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
There was a problem hiding this comment.
Two bugs noticed, the one already mentioned with the Search attributes connector, also one with event frames search (basically impl missing there).
Something else I noticed - when going between Master and this branch, in the search attribute connector in master when Summary data type is selected, the item was not unpacked so the value column had things like this in it:
{'Timestamp': '2024-08-27T08:38:47.0143941Z', 'Value': 5116.335696505253, 'UnitsAbbreviation': '', 'Good': True, 'Questionable': False, 'Substituted': False, 'Annotated': False}
This is fixed here which is good (maybe not by this PR, might be a previous change, not sure). The question is, is this change in behaviour risky? I don't think so, it is more of a fix as Summary was not really usable before - just thought I would mention it.
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…e-search-connector' into fix/comments-for-1-2-2
…e-search-connector' into fix/comments-for-1-2-2
|
Question - for the assets downloader recipe, shouldn't the starttime and endtime fields appear in the UI when summary data type is selected?
|
|
Made the start / end time selectors visible for summary in the recipe with e9ba9d3 |
Fix/comments for 1 2 2
…nual-input-on-attribute-search-connector Feature/sc 190307 add template manual input on attribute search connector
…value-drift Bug/sc 188829 pi time expression value drift
alexbourret
merged commit 7f9d9c1
into
feature/sc-159069-no-more-maxcount
Story details: https://app.shortcut.com/dataiku/story/175067