-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/sc 188829 pi time expression value drift #41
Bug/sc 188829 pi time expression value drift #41
Conversation
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a look through the code so far - had a couple of questions.
(Haven't tested it yet)
Also the change seems to be missing for:
- event frames downloader recipe
- PIWebAPI toolbox connector (probably not important?)
Tested for all components where it is currently implemented (checked startime, endtime and synctime were fixed over a range of requests) - all good 👍 |
…c-188829-pi-time-expression-value-drift
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…e-search-connector' into fix/comments-for-1-2-2
…e-search-connector' into fix/comments-for-1-2-2
Fix/comments for 1 2 2
…nual-input-on-attribute-search-connector Feature/sc 190307 add template manual input on attribute search connector
2ab2f2b
into
feature/sc-175067-add-summary-type-selector
Approved - have tested what was just merged into downstream branch and LGTM |
Story details: https://app.shortcut.com/dataiku/story/188829