Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sc 188829 pi time expression value drift #41

Merged
merged 46 commits into from
Sep 2, 2024
Merged

Bug/sc 188829 pi time expression value drift #41

merged 46 commits into from
Sep 2, 2024

Conversation

alexbourret
Copy link
Contributor

@alexbourret
fix iso_to_epoch when timestamp already epoch
0b35fa1
@alexbourret
parse_pi_time returns epoch or iso
7007b6f
@alexbourret
fix [sc-188829] for attribute search dataset
c295c5e
@alexbourret
Fix [sc-188829] for assets values download recipe
fe2b34e
@alexbourret
beta 3
9d7117f
@alexbourret
Update changelog
1b5263b
@alexbourret
Removing invalid boundary type option
829bf4f
@alexbourret
[sc-190307] add manual input to template selector
220ae47
@alexbourret
update changelog
fc11324
@alexbourret
Update beta version
d14a8bc
@alexbourret
UI fix
3346699
@alexbourret
add variable selector
cbd19ec
@alexbourret
Merge branch 'feature/sc-175067-add-summary-type-selector' into bug/s…
512a6f3 
…c-188829-pi-time-expression-value-drift
@alexbourret
Merge branch 'bug/sc-188829-pi-time-expression-value-drift' into feat…
d7c547f 
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
@alexbourret
fix timestamp drift for event frames search
0f24e04
@alexbourret
Merge branch 'bug/sc-188829-pi-time-expression-value-drift' into feat…
55a18e5 
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
@alexbourret
update beta version
c492294
@alexbourret
replace deprecated utcfromtimestamp
a9f09f6
@alexbourret
fix issue with osi time syntax on interpolated sync time
e4bd6e3
@alexbourret
improved checks on iso timestamp
cceaa29
@alexbourret
simplification
a7aa4c4
@alexbourret
fix unit tests
c850c16
@alexbourret
improving logs around time conversion
7b396a0
@alexbourret
beta 6
f0a57db
@alexbourret
more specific check for error 400
3a66cfc
@alexbourret
renaming and adding comments
8306ad3
@alexbourret
clearer logs
3082c0c
@alexbourret
add doctring to parse_pi_time
ea614c0
@alexbourret
add comment
23e0a75
liamlynch-data
liamlynch-data reviewed Aug 28, 2024
View reviewed changes
Copy link

@liamlynch-data liamlynch-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a look through the code so far - had a couple of questions.
(Haven't tested it yet)

Also the change seems to be missing for:

  • event frames downloader recipe
  • PIWebAPI toolbox connector (probably not important?)

custom-recipes/pi-system-retrieve-list/recipe.json Show resolved Hide resolved
custom-recipes/pi-system-retrieve-list/recipe.py Show resolved Hide resolved
@liamlynch-data
Copy link

Tested for all components where it is currently implemented (checked startime, endtime and synctime were fixed over a range of requests) - all good 👍

@alexbourret
Fix pi time drift for event frame recipe
41a40f3
@alexbourret
more accurate description of expected time format in UI
ffefc5d
@alexbourret
fix typo
0aaa2da
@alexbourret
Merge branch 'feature/sc-175067-add-summary-type-selector' into bug/s…
76da4de 
…c-188829-pi-time-expression-value-drift
@alexbourret
Merge branch 'bug/sc-188829-pi-time-expression-value-drift' into feat…
2128c5c 
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
@alexbourret
Merge branch 'feature/sc-190307-add-template-manual-input-on-attribut…
0226082 
…e-search-connector' into fix/comments-for-1-2-2
@alexbourret
Adding try/catch to regex test
6bd583c
@alexbourret
removed special case for 409 with no retry header
22be5da
@alexbourret
Merge branch 'feature/sc-190307-add-template-manual-input-on-attribut…
f24c443 
…e-search-connector' into fix/comments-for-1-2-2
@alexbourret
row->rows
c576a1c
@alexbourret
Fix issue with summary on non numeric data
3b7a213
@alexbourret
Fix formating issue
4f8b1b1
@alexbourret
Making start_time & end_time visible for summary data type in metrics…
e9ba9d3 
… recipe
@alexbourret
Merge pull request #43 from dataiku/fix/comments-for-1-2-2
402ab64 
Fix/comments for 1 2 2
@alexbourret
Merge pull request #42 from dataiku/feature/sc-190307-add-template-ma…
7f09e5a 
…nual-input-on-attribute-search-connector

Feature/sc 190307 add template manual input on attribute search connector
@alexbourret
Removing interpolater boundary type
ed0a14a
@alexbourret alexbourret merged commit 2ab2f2b into feature/sc-175067-add-summary-type-selector Sep 2, 2024
1 check passed
@liamlynch-data
Copy link

Approved - have tested what was just merged into downstream branch and LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamlynch-data liamlynch-data liamlynch-data left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbourret @liamlynch-data