-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 190307 add template manual input on attribute search connector #42
Conversation
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…ure/sc-190307-add-template-manual-input-on-attribute-search-connector
…e-search-connector' into fix/comments-for-1-2-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mainly fine to me and the features in the card all work fine.
I just have a couple of questions/suggestions about some of the other stuff in the PR
…e-search-connector' into fix/comments-for-1-2-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
7f09e5a
into
bug/sc-188829-pi-time-expression-value-drift
Story details: https://app.shortcut.com/dataiku/story/190307