Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 190307 add template manual input on attribute search connector #42

Conversation

alexbourret
Copy link
Contributor

Copy link

@liamlynch-data liamlynch-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mainly fine to me and the features in the card all work fine.
I just have a couple of questions/suggestions about some of the other stuff in the PR

python-lib/osisoft_plugin_common.py Outdated Show resolved Hide resolved
python-lib/osisoft_plugin_common.py Outdated Show resolved Hide resolved
Copy link

@liamlynch-data liamlynch-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@alexbourret alexbourret merged commit 7f09e5a into bug/sc-188829-pi-time-expression-value-drift Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants