Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding refactored auth [Not be merged] #582

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Adding refactored auth [Not be merged] #582

wants to merge 13 commits into from

Conversation

shreelakshmijoshi
Copy link
Contributor

@shreelakshmijoshi shreelakshmijoshi commented Feb 14, 2025 •
edited
Loading

  • Please refer to the code of conduct : link

  • Please check if the PR fulfills these requirements 📋

  • A new branch is created for the change(s) and the changes are not committed on the main or master branch
  • No credentials or secrets are committed
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, refactor, chore, test, config) 💁 📜
    Refactor, test, config
  • Refactored AuthHandler and JwtAuthenticationServiceImpl to add multiple handlers for authentication and authorization
  • Allowed bearer token to be added in Authorization header for Bearer <JWT-Token> authentication
  • Added helper class RoutingContextHelper to add and fetch objects from routing context
  • Updated and removed existing unit tests accordingly
  • Updated postman collection and Rest Assured Integration tests accordingly

TODO

  • Adding unit tests

  • Updating postman collection to have Bearer

  • Updating example-config

  • Merging DeployerDev to Deployer.java

  • Fixing pmd, checkstyle issues


  • Fixes 🔧 #576, #316

  • Checklist for the current PR 📃

  • I have added the respective changes in the example-config if the changes are made in config
  • For the changes made in example-config, backend components (elasticsearch, flyway files for postgres, immudb schema, rabbitmq) I have notified DX DevOps team by mentioning [at-sign]datakaveri/devops as a PR comment to help facilitate the further necessary changes
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Existing unit tests pass locally with my changes
  • I have added reviewers to check the proposed changes

@shreelakshmijoshi shreelakshmijoshi changed the title Adding refactored auth Adding refactored auth [Not be merged] Feb 14, 2025
@shreelakshmijoshi
Copy link
Contributor Author

retest this please

@shreelakshmijoshi
Copy link
Contributor Author

Hello, could you please update the configs (config-dev.json and config-test.json) with the audience field according to the environment the resource server is deployed on @datakaveri/devops? example-configs are changed in the PR link

"commonConfig": {
    "audience": "rs.iudx.io" 
  },

@karun-singh
Copy link
Collaborator

@manasakoraganji please update configs in jenkins.

@shreelakshmijoshi
Refactor: fix errors
debbeb4
@shreelakshmijoshi
Refactor: Integration tests
a98d7ff 
Update token with Authorization Bearer <JWT> in Rest Assured integration test cases
@manasakoraganji
Copy link

manasakoraganji commented Feb 17, 2025 via email

@shreelakshmijoshi
Copy link
Contributor Author

Thanks @manasakoraganji , @karun-singh

@shreelakshmijoshi
Copy link
Contributor Author

Hello, could you please update the configs (config-dev.json and config-test.json) with the issuer field according to the environment the resource server is deployed on @datakaveri/devops? example-configs are changed in the PR link

 {
   "id": "iudx.resource.server.authenticator.AuthenticationVerticle",
   ...
   "issuer": "cos.iudx.io"
 },

@manasakoraganji
Copy link

manasakoraganji commented Feb 20, 2025 via email

@shreelakshmijoshi
Copy link
Contributor Author

thanks @manasakoraganji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitmashu ankitmashu Awaiting requested review from ankitmashu

@ananjaykumar2 ananjaykumar2 Awaiting requested review from ananjaykumar2

@gopal-mahajan gopal-mahajan Awaiting requested review from gopal-mahajan

@ThorodanBrom ThorodanBrom Awaiting requested review from ThorodanBrom

@Gokul-KG Gokul-KG Awaiting requested review from Gokul-KG

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreelakshmijoshi @karun-singh @manasakoraganji