-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move [CODENAME] data generation into subpkg? #18
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not on Zogotech, but I think it makes sense to have a standard/aligned structure for PDP and Zogotech. I think we just need to be careful not to generalize anything without checking it works for both.
Totally agree. Having pdp/zogotech sub-packages living side by side for a bit, with broadly similar structures, will let us better figure out if/how some functionality can be generalized across them. |
Please rename all references to zogotech to "sample-platform" on our public repo before merging this |
Hey, what's the context for this? ZogoTech isn't a secret... but we could always give it a code-name? Update: I belatedly saw your comment in Slack. |
This PR isn't ready to be merged, or closed. It's a placeholder with a couple notable to-do's that @anzhely never took up. I may revisit in the future, if time permits, but we should leave it open until folks decide otherwise. |
changes
Adds placeholder files for a
generation.CODENAME
subpackage in the sst libTO-DO
synthetic-data/CODENAME/synthetic_data_generator.py
script intogeneration.CODENAME
as lib code, in a form similar to what exists forpdp
scripts/generate_synthetic_pdp_datasets.py
functionality to be source-agnostic, so we could use the same script to generate synthetic data for either pdp or CODENAMEcontext
Currently, synthetic PDP and CODENAME data is generated in similar but different ways, and in two different places in this repo. It would reallly be nice to have these two be consistent and standardized.
questions