Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move [CODENAME] data generation into subpkg? #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bdewilde
Copy link
Member

@bdewilde bdewilde commented Nov 2, 2024

changes

Adds placeholder files for a generation.CODENAME subpackage in the sst lib

TO-DO

  • refactor and move logic in synthetic-data/CODENAME/synthetic_data_generator.py script into generation.CODENAME as lib code, in a form similar to what exists for pdp
  • generalize scripts/generate_synthetic_pdp_datasets.py functionality to be source-agnostic, so we could use the same script to generate synthetic data for either pdp or CODENAME

context

Currently, synthetic PDP and CODENAME data is generated in similar but different ways, and in two different places in this repo. It would reallly be nice to have these two be consistent and standardized.

questions

  • This isn't an urgent priority, but I do think it's worth doing. Do you feel similarly? Any concerns or objections?

@bdewilde bdewilde marked this pull request as ready for review November 2, 2024 14:14
@bdewilde bdewilde requested a review from anzhely as a code owner November 2, 2024 14:14
Copy link
Contributor

@kaylawilding kaylawilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not on Zogotech, but I think it makes sense to have a standard/aligned structure for PDP and Zogotech. I think we just need to be careful not to generalize anything without checking it works for both.

@bdewilde
Copy link
Member Author

bdewilde commented Nov 9, 2024

I think we just need to be careful not to generalize anything without checking it works for both.

Totally agree. Having pdp/zogotech sub-packages living side by side for a bit, with broadly similar structures, will let us better figure out if/how some functionality can be generalized across them.

@rachelauryn
Copy link
Contributor

Please rename all references to zogotech to "sample-platform" on our public repo before merging this

@bdewilde
Copy link
Member Author

bdewilde commented Nov 26, 2024

Please rename all references to zogotech to "sample-platform" on our public repo before merging this

Hey, what's the context for this? ZogoTech isn't a secret... but we could always give it a code-name?

Update: I belatedly saw your comment in Slack.

@bdewilde bdewilde changed the title Move zogotech data generation into subpkg? Move [CODENAME] data generation into subpkg? Nov 27, 2024
@nm3224 nm3224 closed this Dec 23, 2024
@bdewilde
Copy link
Member Author

This PR isn't ready to be merged, or closed. It's a placeholder with a couple notable to-do's that @anzhely never took up. I may revisit in the future, if time permits, but we should leave it open until folks decide otherwise.

@bdewilde bdewilde reopened this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants