Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config and "apply" it - no trailing spaces, sorted imports #271

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

Also removed duplicate .codespellrc since now we specify in pyproject.toml

Inspired by seeing all trailing spaces deleted by @mslw in

Just removed unnecessary exclude for codespell and added tomli as needed
dependency since we define config in pyproject.toml
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "pre-commit run --all || pre-commit run --all",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic requested review from asmacdo and mslw February 5, 2025 19:57
Copy link

codeclimate bot commented Feb 5, 2025

Code Climate has analyzed commit a2b6768 and detected 0 issues on this pull request.

View more on Code Climate.

@yarikoptic
Copy link
Member Author

appveyor -- seems overall in a bad shape

[ "x$PY" != x ] && . ${HOME}/venv${PY}/bin/activate || python3 -m venv ${HOME}/dlvenv && . ${HOME}/dlvenv/bin/activate; ln -s "$VIRTUAL_ENV" "${HOME}/VENV"
The virtual environment was not created successfully because ensurepip is not
available.  On Debian/Ubuntu systems, you need to install the python3-venv
package using the following command.
    apt install python3.8-venv
You may need to use sudo with that command.  After installing the python3-venv
package, recreate your virtual environment.
Failing command: ['/home/appveyor/dlvenv/bin/python3', '-Im', 'ensurepip', '--upgrade', '--default-pip']
ln: failed to create symbolic link '/home/appveyor/VENV' -> '': No such file or directory
Command exited with code 1
Running "on_finish" scripts
while [ -f ~/BLOCK ]; do sleep 5; done
Build failed

should be fixed separately. I do not expect breakages but apparently we do not have any unittesting going on without this appveyor thing... heh, will look into fixing here, but in the longer run I think we need to centralize such testing, filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant